#wave-collect - [Hold on 378314][Held requests] Confirmation to pay is still shown after approving all the requests

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.58-4
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR: #33124
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• Admin and employee are in the Collect workspace.

1. [Employee] Request money from the workspace chat.
2. [Employee] Create two money requests.
3. [Employee] Hold one of the requests and leave the other one unheld.
4. [Admin] Go to expense report.
5. [Admin] Click Approve button.
6. [Admin] Approve all the request.
7. [Admin] Click Pay with Expensify.
8. [Admin] Click on the preview of the request that was previously held.
9. [Admin] Return to expense report.
10. [Admin] Click Pay with Expensify.

Expected Result:

In Step 6, after approving all the requests, and when the request on hold is unheld, paying with Expensify will not show confirmation prompt.

Actual Result:

In Step 6, after approving all the requests, and when the request on hold is unheld, paying with Expensify shows confirmation prompt, with both options showing the same total amount.
When admin visits transaction thread and returns to expense report, clicking on Pay with Expensify button does not show the prompt anymore.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6433349_1711894054589.20240331_220046.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

@sakluger I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[izarutskaya]

Production

[tgolen]

@BartoszGrajdek Is this a regression of #33124 ?

[robertjchen]

It's related to the changes there: #33124 and we'll be addressing it. Not a deploy blocker per the sentiments here 👍

[marcaaron]

Removing the blocker.

[tgolen]

@robertjchen I'm going to assign this to you since you are watching over the PR and handling the regressions. Thank you!

[robertjchen]

Thanks, I can handle 👍

[robertjchen]

More related fixes went out, going to re-test

[trjExpensify]

Did you re-test, @robertjchen?

[sakluger]

@robertjchen friendly bump.

[robertjchen]

Haven't had the chance given ongoing priorities. Let me tag with retest-weekly to get an additional assist.

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[sakluger]

@jliexpensify assigning you to help watch this issue while I'm OOO through May 31. Please handle payment if needed. I'll take back over if it's still open when I return. Nothing much to do on this one.

[mvtglobally]

Issue is not reproducible during KI retests (First week)
https://github.com/Expensify/App/assets/43995119/4d5f5e67-642b-43e7-8ef3-45cf84e0cc57

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[robertjchen]

Thanks, we can close this one out 👍