[HOLD for payment 2024-07-10] [$250] [Wave Collect] Disable all but the default distance rate when feature is disabled same for categories and tags

[mountiny]

Problem

When the Distance Rates feature is disabled in NewDot, the distance rates remain enabled. Similarly to other features in the App, we should disable the rates when the feature is disabled.

However, this is also not yet implemented optimistically for tags and categories. This is an edge case that helps in cases of rare offline usage, and as such, it was not noted as regression.

When we disable the categories and tags feature in the backend, we also disable any enabled categories and tags. We need to do the same optimistically in the client (failure data should revert the state to the one before toggling the feature off).

Solution

When the distance rates feature is turned off in NewDot, go through all the distance rates on the policy and disable them except the Default Rate if available. If it's not available, keep the first rate that you go over as enabled and disable all the rest. We need to keep one enabled.

For tags and categories, make sure to turn off the requiresCategory and requiresTag optimistically and then all the tags, even multi-level.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010ba691024d0e69b3
• Upwork Job ID: 1775299514448031744
• Last Price Increase: 2024-06-07
• Automatic offers:
• getusha | Reviewer | 102703385
• dominictb | Contributor | 102703388

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010ba691024d0e69b3

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @getusha (Internal)

[melvin-bot]

Triggered auto assignment to @kadiealexander (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[mountiny]

Will try to look into this tomorrow

[trjExpensify]

Similarly to other features in the App, we should disable the rates when the feature is disabled (we disable all categories, tags and taxes when the feature is disabled)

Apart from the default or whatever that is, right?

[mountiny]

Correct, one rate will always stay enabled

[mountiny]

working on this one today

[mountiny]

adding tests

[mountiny]

PR is ready for a review

[mountiny]

Also: lets make sure the App handles this optimistically

[melvin-bot]

@mountiny, @kadiealexander, @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@mountiny, @kadiealexander, @getusha Huh... This is 4 days overdue. Who can take care of this?

[mountiny]

Will have to handle this later this week, focusing on more urgent tasks

[melvin-bot]

@mountiny, @kadiealexander, @getusha Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@mountiny, @kadiealexander, @getusha Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@mountiny, @kadiealexander, @getusha 12 days overdue now... This issue's end is nigh!

[melvin-bot]

@mountiny, @kadiealexander, @getusha 12 days overdue now... This issue's end is nigh!

[mountiny]

Will look into this soon

[dominictb]

PR should be ready for review by tomorrow at most.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: disable categories/tags/distance rates when feature is disabled #43637

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @getusha requires payment automatic offer (Reviewer)
• @dominictb requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@getusha] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[mountiny]

this should be ready for payment when the time comes

$250 to @dominictb and to @getusha

[kadiealexander]

@getusha @mountiny do we need a regession test here?

[kadiealexander]

The contracts expired so I've resent them here. Payouts due:

• Contributor: $250 @dominictb (offer)
• Contributor+: $250 @getusha (offer)

Upwork job is here.

[dominictb]

TL;DR: effective today, Thursday, April 4th, 2024 the initial job price for bugs/feature requests will start at $250.

@kadiealexander Hi, this issue was created on Apr 3, so according to the official post here, this one's initial price should remain at $500

[kadiealexander]

Thanks @dominictb, I've updated the offers.

[dominictb]

@kadiealexander I accepted it, thank you

[kadiealexander]

@getusha please share the regression test steps.

[getusha]

[@getusha] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

Regression Test Proposal

1. Go offline
2. Go to workspaces > Select a workspace
3. Go to categories
4. Make sure to have one category enabled
5. Go to more features
6. Disable & Enable Categories feature
7. Go to categories
8. Verify that every category is disabled
9. Go to distance rates
10. Make sure to have at least two rates enabled
11. Go to more features page
12. Disable & Enable distance rates feature
13. Go to Distance rates page
14. Verify that only one distance rate remains enabled
15. Go to Tags page
16. Make sure to have at least one tag enabled
17. Go to more features page
18. Disable & Enable Tags feature
19. Go to Tags page
20. Verify that every options are disabled

Do we agree 👍 or 👎
cc @mountiny @dominictb

[getusha]

Accepted the offer @kadiealexander