[HOLD for payment 2024-05-09] [$250] Generate Workspace Avatar Color based on PolicyID instead of Workspace Name

[grgia]

See https://expensify.slack.com/archives/C03TME82F/p1712094385071259

Right now the workspace icon changes based on the name, but that means that the icon and colors will change every time you modify the name of your workspace, even slightly. For example Expensify UK versus Expensify - UK

Let's hash the policyID instead so the workspace avatar will always remain the same color and the SVG will only change if the first character is modified. For example Expensify UK (E) versus New Expensify - UK (N)

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d4085169c8260375
• Upwork Job ID: 1775449679811973120
• Last Price Increase: 2024-04-03

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d4085169c8260375

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot]

Upwork job price has been updated to $250

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We want the workspace avatar color to be consistent based on first character of workspace name

What is the root cause of that problem?

In here, we're using the full workspace name, not using workspaceID, so whenever workspace name changes, the hash will change and there'll be a new workspace color.

What changes do you think we should make in order to solve the problem?

We can use PolicyID for the hash. To do this, we need to:

• Modify getDefaultWorkspaceAvatarColor here to accept workspaceID instead of workspaceName, and use workspaceID for the hash
• In places that uses getDefaultWorkspaceAvatarColor, pass in workspaceID instead, there'll be some refactoring needed to be able to pass workspaceID to getDefaultWorkspaceAvatarColor (since we're using file name/avatar name, we either need to pass workspaceID as the file name/avatar name or pass a new field for the workspaceID, and use it)

What alternative solutions did you explore? (Optional)

NA

[grgia]

We want the workspace avatar color to be consistent based on first character of workspace name
@nkdengineer

The only change is that the workspace color will be based off the policyID. The Workspace SVG will still be based on the name

[melvin-bot]

This issue has not been updated in over 15 days. @rushatgabhane, @isabelastisser, @grgia, @nkdengineer eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Generate Workspace Avatar Color based on PolicyID instead of Workspace Name #39637

If no regressions arise, payment will be issued on 2024-05-09. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @nkdengineer requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[isabelastisser]

@rushatgabhane, please complete the BZ list, and I will process the payments tomorrow. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @rushatgabhane owed $250 via NewDot
• ROLE: @nkdengineer paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@isabelastisser)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1775449679811973120/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[isabelastisser]

Bump @rushatgabhane for an update, thanks!

[rushatgabhane]

This is a new feature, so we should add regression steps.

1. Open Workspace setting
2. Change workspace name
3. Verify that: Workspace icon don't change color

[isabelastisser]

Payment Summary

Upwork Job

Reviewer: @rushatgabhane owed $250 via NewDot
ROLE: @nkdengineer paid $250 via Upwork (https://www.upwork.com/nx/wm/offer/102291242)

[shawnborton]

I thought this PR introduced a bunch of regressions? Should we be paying out the bounty, or wait until all of the regressions are fixed?

@grgia can you confirm please?

[shawnborton]

Here's the link to the PR that should fix some of the regressions: #41485

[isabelastisser]

Bump @grgia

[grgia]

@rushatgabhane @isabelastisser yes, it did introduce a handful of regressions. Would you please calculate payment with the regression penalty

[isabelastisser]

Thanks, @grgia! Discussion here.

[isabelastisser]

We've discussed this internally and decided to reduce the payment amounts due to the PR regressions.

Payment Summary

Upwork Job

Reviewer: @rushatgabhane owed $100 via NewDot (PENDING)
ROLE: @nkdengineer paid $100 via Upwork (https://www.upwork.com/nx/wm/offer/102291242)

[JmillsExpensify]

$100 approved for @rushatgabhane