Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat- Nested quotes disappear when editing if different levels of quotes are present #39502

Closed
1 of 6 tasks
lanitochka17 opened this issue Apr 3, 2024 · 10 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause

Comments

@lanitochka17
Copy link

lanitochka17 commented Apr 3, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.59-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Open a chat
  3. Type ">>>3"
  4. Go to a new line and type ">>2" and send the message
  5. Edit the message sent on step 4

Expected Result:

The message appears as it has been sent when getting into editing mode

Actual Result:

The second quoted message sent on the second line loses its quote levels

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6436444_1712131910646.bandicam_2024-04-03_11-06-45-849.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 3, 2024
Copy link

melvin-bot bot commented Apr 3, 2024

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@lanitochka17
Copy link
Author

@slafortune FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@melvin-bot melvin-bot bot added the Overdue label Apr 5, 2024
Copy link

melvin-bot bot commented Apr 8, 2024

@slafortune Eep! 4 days overdue now. Issues have feelings too...

@shubham1206agra
Copy link
Contributor

#38199 should have fixed this problem.
cc @allroundexperts @andrey010

@andrey010
Copy link
Contributor

@shubham1206agra we have a similar issue but the issue was about editing one line of text, I am not sure that ExpensiMark.js worked correct before for parsing two line with quotes

@shubham1206agra
Copy link
Contributor

The solution should have been general.

@allroundexperts Is there something I am missing here?

@andrey010
Copy link
Contributor

my solution fixed issue described here #38199

@slafortune
Copy link
Contributor

I can add the retest label

@melvin-bot melvin-bot bot removed the Overdue label Apr 10, 2024
@slafortune slafortune added Overdue retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause labels Apr 10, 2024
@allroundexperts
Copy link
Contributor

allroundexperts commented Apr 10, 2024

#38199 should have fixed this problem.

Hm... These markdown issues are normally very tricky. Although for the case above, I think its a different problem altogether. In #38199, we were dealing with a single level of quotes. Like with our regexes in the expensify-common, I think the best way would be to keep on adding these test cases to unit test file as we find them.

@slafortune
Copy link
Contributor

Yep - looks like this is fixed now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause
Projects
Status: Done
Development

No branches or pull requests

5 participants