-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat- Nested quotes disappear when editing if different levels of quotes are present #39502
Comments
Triggered auto assignment to @slafortune ( |
@slafortune FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
@slafortune Eep! 4 days overdue now. Issues have feelings too... |
#38199 should have fixed this problem. |
@shubham1206agra we have a similar issue but the issue was about editing one line of text, I am not sure that ExpensiMark.js worked correct before for parsing two line with quotes |
The solution should have been general. @allroundexperts Is there something I am missing here? |
my solution fixed issue described here #38199 |
I can add the retest label |
Hm... These markdown issues are normally very tricky. Although for the case above, I think its a different problem altogether. In #38199, we were dealing with a single level of quotes. Like with our regexes in the |
Yep - looks like this is fixed now 👍 |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.59-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
The message appears as it has been sent when getting into editing mode
Actual Result:
The second quoted message sent on the second line loses its quote levels
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6436444_1712131910646.bandicam_2024-04-03_11-06-45-849.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: