Taxes - Tax amount input in transaction thread is not auto-focused

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.60-1
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• User is an employee of Collect workspace that has taxes.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Start manual request flow.
4. In confirmation page, click Show more > Tax amount.
5. Note that Tax amount input is auto focused.
6. Create the request with tax.
7. Go to transaction thread.
8. Click Tax amount.

Expected Result:

Tax amount input in transaction thread will be auto focused.

Actual Result:

Tax amount input in transaction thread is not auto focused.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6437921_1712233909903.tax_amount_focus.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[rlinoz]

I think this is related to this PR #33927 since it is a new feature.

cc: @alitoshmatov @rezkiy37

[rlinoz]

But we don't have to block on this, so removing the label.

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Taxes - Tax amount input in transaction thread is not auto-focused

What is the root cause of that problem?

The main problem with the issue is that when we pass ref we can't get value from textInput because by default our ref is null

App/src/pages/EditRequestTaxAmountPage.tsx

Line 55 in c3c4a07

ref={textInput}

App/src/pages/iou/steps/MoneyRequestAmountForm.tsx

Lines 290 to 293 in 9d8c337

	} else if (forwardedRef?.current) {
	// eslint-disable-next-line no-param-reassign
	forwardedRef.current = ref;
	}

What changes do you think we should make in order to solve the problem?

To fix this issue we can make logic from others' screen and pass like

ref={(e) => (textInput.current = e)}

App/src/pages/EditRequestTaxAmountPage.tsx

Line 55 in c3c4a07

ref={textInput}

Or we can update this condition and make null is available value ( or just ignore only undefined )

App/src/pages/iou/steps/MoneyRequestAmountForm.tsx

Line 290 in 9d8c337

} else if (forwardedRef?.current) {

What alternative solutions did you explore? (Optional)

NA

[MonilBhavsar]

We'll be fixing this as a regression

[teneeto]

Hi, I'm Eto from Callstack - expert contributor group - and I would like to take care of this issue.

[MonilBhavsar]

PR is merged!

[rlinoz]

Deployed to production: #39675 (comment)

So I am closing this one.