Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxes - System message for tax amount edit shows USD first, then changes to correct currency #39605

Closed
6 tasks done
kbecciv opened this issue Apr 4, 2024 · 9 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Apr 4, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.60-1
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • The Collect workspace has taxes.
  • The default workspace currency is not USD.
  1. Go to staging.new.expensify.com
  2. Go to Collect workspace chat.
  3. Create a manual request with tax in non-USD currency.
  4. Go to transaction thread.
  5. Click Tax amount.
  6. Edit the amount and save it.

Expected Result:

The system message for tax amount edit will show the correct tax currency.

Actual Result:

The system message for tax amount edit shows the tax in USD first, then changes to the correct currency.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6437929_1712233917202.tax_system_message.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0177cce5def94cedf6
  • Upwork Job ID: 1775991223827992576
  • Last Price Increase: 2024-04-04
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Apr 4, 2024
Copy link

melvin-bot bot commented Apr 4, 2024

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@kbecciv
Copy link
Author

kbecciv commented Apr 4, 2024

We think that this bug might be related to #wave-collect - Release 1

@MonilBhavsar
Copy link
Contributor

This can be demoted from deploy blocker. Not a major issue. Feel free to assign it to me. Happy to handle it.
We can handle as a regression from #33927

@jasperhuangg jasperhuangg added Internal Requires API changes or must be handled by Expensify staff Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment labels Apr 4, 2024
Copy link

melvin-bot bot commented Apr 4, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0177cce5def94cedf6

Copy link

melvin-bot bot commented Apr 4, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Santhosh-Sellavel (Internal)

Copy link

melvin-bot bot commented Apr 4, 2024

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MonilBhavsar
Copy link
Contributor

PR is up for review!

@MonilBhavsar
Copy link
Contributor

PR is merged! No further action required here

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Apr 29, 2024
Copy link

melvin-bot bot commented Apr 29, 2024

This issue has not been updated in over 15 days. @sakluger, @MonilBhavsar eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants