[HOLD for payment 2024-05-08] [$250] Profile - Display name is not updating in "Share Somewhere" section

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.60-1
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to Profile.
2. Add or change the Display name.
3. Use FAB to assign a task.
4. Add a title and click "Next" to share somewhere.
5. Notice that the Display name isn't updated for the account email (email signed in).

Expected Result:

When the Display name is changed, it should be updated in the "Share Somewhere" section for the account email (email signed in).

Actual Result:

Display name is not updating in "Share Somewhere" section

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6437941_1712234508566.Screen_Recording_2024-04-04_at_1.14.37_AM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0109207e4c67cd7686
• Upwork Job ID: 1776016111925432320
• Last Price Increase: 2024-04-11
• Automatic offers:
• hungvu193 | Reviewer | 0
• nkdengineer | Contributor | 0

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @bondydaa (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #vip-vsb

[bondydaa]

I'm looking into this, nothing in the checklist stands out to me that might be something that broke this so having to dive into the code and see what exactly gets called.

[bondydaa]

okay i don't think it's a problem with the API, i see the response coming back properly with the updated data

And I see in the onyx db that it's been updated there

So this makes me think that for some reason the Share Somewhere component isn't properly subscribing to the onyx data or something so going to take a closer look at that.

[bondydaa]

Hmm this PR is sus to me after looking at the components involved here: #38207

[bondydaa]

okay yes I believe I've confirmed this by testing locally.

checking out 1.4.60-1 locally I see the same behavior and then reverting it I can't reproduce it anymore.

cc @grgia @hungvu193 @TMisiukiewicz can you take a look here?

[bondydaa]

I guess what we need is a way to invalidate the option list cache when personal details are updated, if there is a way to do that in the PR can you let me know?

or if that's still to come then maybe we consider this not a blocker?

makes me think of my favorite tweet 😂 https://twitter.com/codinghorror/status/506010907021828096

[jasperhuangg]

@bondydaa This seems like a pretty minor bug–and since we've already narrowed down which PR it's coming from I think we can just mark it NAB and have @TMisiukiewicz look into a fix

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[bondydaa]

alrighty, this might not be limited to only the Share Somewhere option so it the option list for many of the places updated in that PR could fail to properly update with new personal data.

I do agree it's probably fairly minor for now and can be fixed in a follow up PR though.

[bondydaa]

Chatted with Vit as well and we can also let this go through as external I think so throwing the label on. going to assign @hungvu193 as well though since you helped with the first PR.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0109207e4c67cd7686

[melvin-bot]

Current assignee @hungvu193 is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

@JmillsExpensify, @bondydaa, @hungvu193 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[nkdengineer]

@hungvu193 The PR is here.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.68-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update report option when personal detail is changed #40167

If no regressions arise, payment will be issued on 2024-05-08. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment automatic offer (Reviewer)
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hungvu193] The PR that introduced the bug has been identified. Link to the PR:
• [@hungvu193] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hungvu193] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hungvu193] Determine if we should create a regression test for this bug.
• [@hungvu193] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[hungvu193]

• The PR that introduced the bug has been identified. Link to the PR: perf: Cache search options #38207
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug: No

This is new feature, we can treat it as a follow up of #38207

[melvin-bot]

@JmillsExpensify, @bondydaa, @hungvu193, @nkdengineer Huh... This is 4 days overdue. Who can take care of this?

[hungvu193]

Bump @JmillsExpensify for payment here

[JmillsExpensify]

Payment summary:

• Contributor: @nkdengineer $250
• Contributor+: @hungvu193 $250

[JmillsExpensify]

Both Contributor contracts paid out via Upwork, so I'm closing this issue.