[HOLD - EApp #20354] Start chat - No hover effect on Add to group button

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.60-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Request money > Manual
3. Enter amount and proceed to contact list
4. Hover over split button
5. Go to FAB > Start chat > Chat
6. Hover over Add to group button

Expected Result:

There will be hover effect on Add to group button

Actual Result:

There is no hover effect on Add to group button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6438139_1712245526515.20240404_234032.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Start chat - No hover effect on Add to group button

What is the root cause of that problem?

We disable default hover from the custom list button here:

App/src/components/OptionRow.tsx

Line 277 in 13d6d39

shouldUseDefaultHover={false}

What changes do you think we should make in order to solve the problem?

We should enable it,

• By Adding a custom prop, or
• By Enabling button hover all usecases (since button hovering is standard for E/App, we can test and enable for all components using this)

[nkdengineer]

It should be held for #38610

[alexpensify]

Thanks for flagging @nkdengineer. @rushatgabhane I see you are the C+ for the issue mentioned here. Do you agree with this hold? Thanks!

[alexpensify]

No update yet, waiting for confirmation if we should move this to Weekly and keep it on hold.

[alexpensify]

Still waiting for feedback here.

[rushatgabhane]

@alexpensify yes i think it's fine to hold here

[trjExpensify]

Why did this get put into #wave-collect? It's a bug in Start Chat.

[alexpensify]

My mistake @trjExpensify

[dragnoir]

This issue is fixed within #38610

[alexpensify]

Thank you for that update, I'm going to close this GH then.