Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Track Tax] Expense request with tax amount higher than the tax rate limit can be created #39703

Closed
6 tasks done
izarutskaya opened this issue Apr 5, 2024 · 15 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@izarutskaya
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.60-8
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR: #33927
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

  • Collect workspace has tax rates.
  • Workspace Currency Default has 20% tax.
  • Foreign Currency Default has 10% tax.
  1. Go to staging.new.expensify.com
  2. Go to Collect workspace chat.
  3. Start manual request flow using foreign currency.
  4. In confirmation page, click Show more.
  5. Keep the default tax rate, where it applies Workspace Currency Default (20%).
  6. Click Tax amount.
  7. Manually edit the tax amount to within 10% to 20% tax amount.
  8. Create the request.
  9. Go to transaction thread.
  10. Note that tax rate changes to Foreign Currency Default with 10% tax.
  11. Note the tax amount.

Expected Result:

In the transaction thread, the tax amount should readjust to the maximum limit of Foreign Currency Default (10%).

Actual Result:

In the transaction thread, the tax amount does not readjust to the maximum limit of Foreign Currency Default (10%).
It still shows the tax amount entered during the creation (Step 7), which is higher than the maximum limit of Foreign Currency Default (10%).

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6438830_1712298872398.20240405_142523.mp4

View all open jobs on GitHub

@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 5, 2024
Copy link

melvin-bot bot commented Apr 5, 2024

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Apr 5, 2024

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 5, 2024
Copy link
Contributor

github-actions bot commented Apr 5, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

@kevinksullivan I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

We think this issue might be related to the #collect project.

@MonilBhavsar MonilBhavsar removed the DeployBlockerCash This issue or pull request should block deployment label Apr 5, 2024
@MonilBhavsar MonilBhavsar assigned MonilBhavsar and unassigned flodnv Apr 5, 2024
@MonilBhavsar
Copy link
Contributor

Demoting from deploy blocker as issue lies on server side

@MonilBhavsar
Copy link
Contributor

Self assigning and I'll take a look

@MonilBhavsar MonilBhavsar added Daily KSv2 and removed Hourly KSv2 labels Apr 5, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 8, 2024
@MonilBhavsar MonilBhavsar changed the title Taxes - Expense request with tax amount higher than the tax rate limit can be created [HOLD #39616]Taxes - Expense request with tax amount higher than the tax rate limit can be created Apr 8, 2024
@MonilBhavsar
Copy link
Contributor

Putting this on HOLD for so client can send correct taxAmount param #39616

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 8, 2024
@MonilBhavsar MonilBhavsar added Weekly KSv2 and removed Daily KSv2 labels Apr 11, 2024
@melvin-bot melvin-bot bot removed the Overdue label Apr 11, 2024
@MonilBhavsar
Copy link
Contributor

on HOLD

@melvin-bot melvin-bot bot added the Overdue label Apr 19, 2024
@MonilBhavsar
Copy link
Contributor

Still on HOLD

@melvin-bot melvin-bot bot removed the Overdue label Apr 22, 2024
@kevinksullivan
Copy link
Contributor

Agree with wave-collect here.

@kevinksullivan
Copy link
Contributor

Still on hold for #39616

@trjExpensify trjExpensify changed the title [HOLD #39616]Taxes - Expense request with tax amount higher than the tax rate limit can be created [HOLD #39616] [Track Tax] Expense request with tax amount higher than the tax rate limit can be created May 2, 2024
@melvin-bot melvin-bot bot added the Overdue label May 8, 2024
@kevinksullivan
Copy link
Contributor

@MonilBhavsar still looks like this is held?

@melvin-bot melvin-bot bot removed the Overdue label May 9, 2024
@MonilBhavsar
Copy link
Contributor

Yes, correct. Very close for the other PR to merge, retest this and hopefully close this issue

@MonilBhavsar
Copy link
Contributor

We've merged the PR and this issue is not reproducible on main. So closing

@github-project-automation github-project-automation bot moved this from Polish to Done in [#whatsnext] #wave-collect May 13, 2024
@MonilBhavsar MonilBhavsar changed the title [HOLD #39616] [Track Tax] Expense request with tax amount higher than the tax rate limit can be created [Track Tax] Expense request with tax amount higher than the tax rate limit can be created May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

4 participants