[Track Tax] Expense request with tax amount higher than the tax rate limit can be created

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.60-8
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR: #33927
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• Collect workspace has tax rates.
• Workspace Currency Default has 20% tax.
• Foreign Currency Default has 10% tax.

1. Go to staging.new.expensify.com
2. Go to Collect workspace chat.
3. Start manual request flow using foreign currency.
4. In confirmation page, click Show more.
5. Keep the default tax rate, where it applies Workspace Currency Default (20%).
6. Click Tax amount.
7. Manually edit the tax amount to within 10% to 20% tax amount.
8. Create the request.
9. Go to transaction thread.
10. Note that tax rate changes to Foreign Currency Default with 10% tax.
11. Note the tax amount.

Expected Result:

In the transaction thread, the tax amount should readjust to the maximum limit of Foreign Currency Default (10%).

Actual Result:

In the transaction thread, the tax amount does not readjust to the maximum limit of Foreign Currency Default (10%).
It still shows the tax amount entered during the creation (Step 7), which is higher than the maximum limit of Foreign Currency Default (10%).

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6438830_1712298872398.20240405_142523.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@kevinksullivan I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[MonilBhavsar]

Demoting from deploy blocker as issue lies on server side

[MonilBhavsar]

Self assigning and I'll take a look

[MonilBhavsar]

Putting this on HOLD for so client can send correct taxAmount param #39616

[MonilBhavsar]

on HOLD

[MonilBhavsar]

Still on HOLD

[kevinksullivan]

Agree with wave-collect here.

[kevinksullivan]

Still on hold for #39616

[kevinksullivan]

@MonilBhavsar still looks like this is held?

[MonilBhavsar]

Yes, correct. Very close for the other PR to merge, retest this and hopefully close this issue

[MonilBhavsar]

We've merged the PR and this issue is not reproducible on main. So closing