-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Track Tax] Expense request with tax amount higher than the tax rate limit can be created #39703
Comments
Triggered auto assignment to @kevinksullivan ( |
Triggered auto assignment to @flodnv ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@kevinksullivan I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
We think this issue might be related to the #collect project. |
Demoting from deploy blocker as issue lies on server side |
Self assigning and I'll take a look |
Putting this on HOLD for so client can send correct taxAmount param #39616 |
on HOLD |
Still on HOLD |
Agree with wave-collect here. |
Still on hold for #39616 |
@MonilBhavsar still looks like this is held? |
Yes, correct. Very close for the other PR to merge, retest this and hopefully close this issue |
We've merged the PR and this issue is not reproducible on main. So closing |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.60-8
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR: #33927
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Precondition:
Expected Result:
In the transaction thread, the tax amount should readjust to the maximum limit of Foreign Currency Default (10%).
Actual Result:
In the transaction thread, the tax amount does not readjust to the maximum limit of Foreign Currency Default (10%).
It still shows the tax amount entered during the creation (Step 7), which is higher than the maximum limit of Foreign Currency Default (10%).
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6438830_1712298872398.20240405_142523.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: