[HOLD for payment 2024-05-06] App lags and every actions happen with delay

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.61-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Open the app and log in
2. Go to different areas (start a chat, request money, open an expense report, switch from one workspace to another, go to profile setting and back to the chat view etc)

Expected Result:

There is no significant delay when navigating to different areas of the app

Actual Result:

The app lags and almost every action happens with a delay

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6442740_1712605944864.video_2024-04-08_12-53-41.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #vip-vsb

[Julesssss]

I'm not seeing the same performance issue on Android native. As the issue is also a generic performance issue I'm demoting it from a blocker.

[roryabraham]

I think this is too generic to be useful as an issue, but I'll bring it up in #newdot-performance

[Julesssss]

Further investigation into homepage initial render shows this is an outlier:

[Julesssss]

Continuing discussion in Slack, as there is data showing an increase in render time for app switching.

[Julesssss]

I have some more information from QA:

Issue still occurs. Reproduced in android only and not in iOS. It is affecting mostly the chats and LHN.

Devices reproduced

• Samsung Galaxy A52s 5G / Android 14
• iPhone 12 pro / iOS 17.4
• Xiaomi Redmi Note 10 (4/128) / Android 12

Videos:

Screenrecorder-2024-04-10-16-18-49-610.1.mp4

MWHB9525.1.MP4

az_recorder_20240410_144434.1.mp4

[Julesssss]

Applause have provided further logs and reproduction steps here

[Julesssss]

Applause user accounts:
applausetester+0111pm@applause.expensifail.com, applausetester+0403rbandroid@applause.expensifail.com applausetester+bpcategory@applause.expensifail.com - Android
applausetester+110523pm@applause.expensifail.com - iOS

Logs for all Android timing events this week

iPhone Logs

• Tap the workspace switcher
• Select a workspace
• Open the workspace switcher
• Select another workspace
• Navigate to the workspace switcher
• Tap Expensify to show all chats
• Tap FAB > Request money > Manual
• Enter amount
• Select workspace
• Enter description, merchant and request money
• Open the expense report

App_Info_1.4.61-6 (3).json
Profile_trace_for_1.4.61-6 (3).cpuprofile

[adhorodyski]

Investigated to be the bottleneck on getSearchText() processing for a lot of personalDetails on an account (string concat).

Linked by @danieldoglas to #38887 - reverted in #40019. The initial bug needs a new solution to the problem.

[Julesssss]

Great find. Lets just make sure to check our internal timings revert to normal before closing this issue out

[roryabraham]

ok, looks like this has probably been fixed but we'll double-check before shipping the checklist

[roryabraham]

requested retest: https://expensify.slack.com/archives/C9YU7BX5M/p1713199986484979

[kavimuru]

Issue fixed now.

screen-20240415-130445.mp4

[roryabraham]

kk, closing this out

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Improve getSearchText perf #40193

If no regressions arise, payment will be issued on 2024-05-06. 🎊

[melvin-bot]

Current assignee @mallenexpensify is eligible for the Bug assigner, not assigning anyone new.

[mallenexpensify]

@jayeshmangwani , can you please accept the job and reply here once you have?
https://www.upwork.com/nx/job-post/custom/preview?uid=1798493059688799274
(price was dropped to $250 on 4/4 and you were assigned on 4/15 to do the review)

[jayeshmangwani]

Thanks for the quick help 🙏 @mallenexpensify , you sent the upwork offer, but now I am getting paid via NewDot payments, though i have no issues with the Upwork offer for this issue

[jayeshmangwani]

can you please accept the job and reply here once you have?

@mallenexpensify Offer accepted

[mallenexpensify]

Contributor+: @jayeshmangwani paid $250 via Upwork.

d'oh, sorry about that, you'd think that I would know, having invited you to NewDot payments. More of a knee-jerk habit. I paid via Upwork cuz I already clicked the button before I saw your comment abovve, sorry.