[HOLD for payment 2024-05-06] [$250] [Search v1] Create Search widget

[luacmartins]

Section from design doc

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013bed533d17650a06
• Upwork Job ID: 1781315585886089216
• Last Price Increase: 2024-04-19

[melvin-bot]

@luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

[luacmartins]

@Kicu please comment on this issue so I can assign it to you :)

[Kicu]

hey, I confirm I will be working on this :)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013bed533d17650a06

[melvin-bot]

Triggered auto assignment to @mallenexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[Zarrrii08]

https://www.upwork.com/freelancers/zaryabhayatkhan

[melvin-bot]

📣 @Zarrrii08! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

@Kicu, @luacmartins, @mallenexpensify, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[luacmartins]

@Kicu is still working on this

[Kicu]

I expect the PR to be done today

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Search v1] Create Search widget #40903

If no regressions arise, payment will be issued on 2024-05-06. 🎊

For reference, here are some details about the assignees on this issue:

• @Kicu does not require payment (Contractor)
• @dukenv0307 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@dukenv0307] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[mallenexpensify]

@Kicu , @dukenv0307 can you please submit a proposal or accept the job and reply here once you have?
https://www.upwork.com/jobs/~013bed533d17650a06

[Kicu]

@mallenexpensify Unsure what you mean, this issue was already done and PR for it is merged.

[luacmartins]

The PR has been in prod for 7 days now. @Kicu is from SWM and worked on the implementation.

[dukenv0307]

@Kicu , @dukenv0307 can you please submit a proposal or accept the job and reply here once you have?

Thanks @mallenexpensify! I applied to the job

[mallenexpensify]

@dukenv0307 can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~013bed533d17650a06

[dukenv0307]

@mallenexpensify Offer accepted thanks 🙏

[mallenexpensify]

Contributor+: @dukenv0307 paid $250 via Upwork

@dukenv0307 can you propose the steps for the TestRail update? We def want one for the new feature. Thx

[dukenv0307]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: N/A
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression test:

1. Login with the new account
2. Go to Settings > Troubleshoot > New Search Page
3. Verify that the "empty" view is shown
4. Logout
5. Login with an account that has many chats
6. Go to Settings > Troubleshoot > New Search Page
7. Verify that the item list is shown

Do we 👍 or 👎

[dukenv0307]

@mallenexpensify I completed the checklist

[Kicu]

The search feature is not yet fully complete so Im not sure how useful it is to write these test steps. Perhaps we should do these later?
For example:

Go to Settings > Troubleshoot > New Search Page

This is not how the actual navigation will work, this is temporary for developing the feature.

[luacmartins]

As @Kicu said, no tests needed at this time. We'll add them as part of the project wrap-up.

[mallenexpensify]

Groovy, closing out then. Thx y'all.