[HOLD for payment 2024-07-10] [$500] critical: Chat is not marked as read when receiving a message being in the chat

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.62-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @iwiznia
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1711638025134599

Action Performed:

1. Go to any chat
2. Open another tab or not having the window on focus
3. Receive a notification for a new message in the chat
4. Click on the notification and land on the chat
5. Chat should be marked since message is read
6. Go to another chat
7. Again open the chat where the message is received

Expected Result:

In step 4 or in step 6 LHN should be unbold as the message is read

Actual Result:

Still showing as unread, user has to click back to the chat as in step 7 to show as "read"

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Chat.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018e5ebea78782ee33
• Upwork Job ID: 1778874424236658688
• Last Price Increase: 2024-07-03
• Automatic offers:
• abdulrahuman5196 | Reviewer | 102764320
• allgandalf | Contributor | 102884646

Issue Owner

Current Issue Owner: @dylanexpensify

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dylanexpensify]

Yep, could repro, though low value

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018e5ebea78782ee33

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[iwiznia]

though low value

I disagree, this is happening to me every day, many times a day. It makes the app look broken as it makes you have to click out and back in to mark as read.

[ShridharGoel]

What is the expected behaviour? Should we quickly mark it as read when the user switches to the tab? Then the user wouldn't be able to know that there are some new messages, and where the new messages start from. Maybe we can have some interval, like mark it as read after 4 seconds (just as an example).

[giorgi17]

Doesn't show notifications for me like in the video, do I need to activate something? trying to replicate the issue. @dylanexpensify

[melvin-bot]

📣 @giorgi17! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[dylanexpensify]

I disagree, this is happening to me every day, many times a day. It makes the app look broken as it makes you have to click out and back in to mark as read.

happy to move this higher then @iwiznia!

[dylanexpensify]

Doesn't show notifications for me like in the video, do I need to activate something? trying to replicate the issue. @dylanexpensify

@giorgi17 ah make sure your preferences allow for notifications from New Expensify!

[dylanexpensify]

What is the expected behaviour? Should we quickly mark it as read when the user switches to the tab? Then the user wouldn't be able to know that there are some new messages, and where the new messages start from. Maybe we can have some interval, like mark it as read after 4 seconds (just as an example).

@ShridharGoel simple - just if the user clicks on the notification and reads the chat, it's marked as read then and there (aka unbolds instantly when opening the chat).

[ShridharGoel]

simple - just if the user clicks on the notification and reads the chat, it's marked as read then and there (aka unbolds instantly when opening the chat).

@dylanexpensify And what about the "New" marker that we show above the unread messages?

[dylanexpensify]

@ShridharGoel that should disappear at the same rate it does for any new message! cc @Expensify/design not sure if we have a limit distinguished for this

[shawnborton]

I would think the New marker would stay in the chat as long as you are looking at the chat. This way if you do scroll up and down in the chat, you at least have a marker that shows you where the new messages start. If you navigate away and come back, then the new marker would disappear. Is that what you are asking Dylan?

[giorgi17]

Doesn't show notifications for me like in the video, do I need to activate something? trying to replicate the issue. @dylanexpensify

@giorgi17 ah make sure your preferences allow for notifications from New Expensify!

I did, but still couldn't see notifications, perhaps it's not reproducible on local. However, I've found similar issue, where receiving the message and opening It doesn't unbold the text, it's still seen as "unread". It only works after 1 minute or so. See the footage
My diagnosis is that from frontend, the message creation time is sent correctly, but then the response has the time 1.5 minutes later, because of this, the logic is flawed. Read time is always 1.5 minute earlier if you quickly try to view the new message upon receiving it, you basically need to wait 2 minutes so you can then open the chat and it'll then pick that it's now read, so, for the first 2 minutes, this logic doesn't work. This is why I was trying to find the backend code, it's a huge project, could you tell me where I could see the backend code, or Is there one at all in this project. Maybe i could find the reason there for this time difference.

The same reason could be in the case of notification. Fixing this requires figuring out, why after sending the right message creation time, i receive the time from the database that is 1.5 minutes older.

You can see this difference in this pics:
This is what Is sent from frontend - lastVisibleActionCreated .

This is what I got back:

About 1.5 minute difference.

This is the line where it's compared:

lastReadTime is I believe created in frontend, but the lastVisibleActionCreated is received from backend, which is incorrect by almost 2 minutes, so if chat opened in that timeline, in the first 2 minutes, it won't "unbold" the name and it'll see it as unread.

[melvin-bot]

@abdulrahuman5196, @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@abdulrahuman5196, @dylanexpensify Still overdue 6 days?! Let's take care of this!

[melvin-bot]

📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[allgandalf]

btw, this is marked critical, the compensation should be $500 right? @dylanexpensify

[dylanexpensify]

Correct, thanks @allgandalf!

[melvin-bot]

Upwork job price has been updated to $500

[allgandalf]

melvin again changed the price to 250 ;)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Marking as read when coming from notification #43919

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @gedu does not require payment (Contractor)
• @allgandalf requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allgandalf] The PR that introduced the bug has been identified. Link to the PR:
• [@allgandalf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allgandalf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allgandalf] Determine if we should create a regression test for this bug.
• [@allgandalf] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Upwork job price has been updated to $500

[dylanexpensify]

payment coming up!

[allgandalf]

• The PR that introduced the bug has been identified. Link to the PR: [NoQA] change webpack config and rename .web files to .website files #32548

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/32548/files#r1671879292

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A

• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Sign in with any user in MacOS Web Chrome/Desktop.

2. In Chrome: Change tab so ND is not focused

3. Then sign in with any user in Safari, this user must have the user on Chrome as friend or be able to chat

4. From Safari send a message to Chrome user

5. Wait for the notification to show up on Chrome, click it

6. ND should show up, open the right report and on LHN verify that the report title of current user chat isn't bold

Do we agree 👍 or 👎

[dylanexpensify]

Payment summary:

• Contributor: @gedu $500
• Contributor+: @allgandalf $500

Please apply/request!

[dylanexpensify]

Done!