Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-05-02] [QAB] [Follow-up] Skip confirmation screen for track expenses #40282

Closed
Gonals opened this issue Apr 16, 2024 · 11 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.

Comments

@Gonals
Copy link
Contributor

Gonals commented Apr 16, 2024

HELD on https://github.com/Expensify/Expensify/issues/378892 and #38051

Since Track functionality was added later, we are currently not skipping the confirmation screen in track flows. As a follow up to this issue, we want to do so.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0163a5f58b3ed495c7
  • Upwork Job ID: 1780188713666760704
  • Last Price Increase: 2024-04-16
@Gonals Gonals added Weekly KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. labels Apr 16, 2024
@Gonals Gonals self-assigned this Apr 16, 2024
Copy link

melvin-bot bot commented Apr 16, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0163a5f58b3ed495c7

Copy link

melvin-bot bot commented Apr 16, 2024

Triggered auto assignment to @JmillsExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 16, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @hoangzinh (Internal)

Copy link

melvin-bot bot commented Apr 16, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

@trjExpensify trjExpensify moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Apr 16, 2024
@trjExpensify trjExpensify changed the title [HOLD][QAB] [Follow-up] Skip confirmation screen for track expenses [HOLD PRs: #39413 & #39640][QAB] [Follow-up] Skip confirmation screen for track expenses Apr 16, 2024
@Gonals Gonals changed the title [HOLD PRs: #39413 & #39640][QAB] [Follow-up] Skip confirmation screen for track expenses [QAB] [Follow-up] Skip confirmation screen for track expenses Apr 19, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 19, 2024
@melvin-bot melvin-bot bot changed the title [QAB] [Follow-up] Skip confirmation screen for track expenses [HOLD for payment 2024-05-02] [QAB] [Follow-up] Skip confirmation screen for track expenses Apr 25, 2024
Copy link

melvin-bot bot commented Apr 25, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 25, 2024
Copy link

melvin-bot bot commented Apr 25, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-05-02. 🎊

For reference, here are some details about the assignees on this issue:

  • @hoangzinh requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Apr 25, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@hoangzinh] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot removed the Weekly KSv2 label May 1, 2024
@melvin-bot melvin-bot bot added the Daily KSv2 label May 1, 2024
Copy link

melvin-bot bot commented May 2, 2024

Payment Summary

Upwork Job

  • ROLE: @hoangzinh paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@trjExpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1780188713666760704/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@trjExpensify
Copy link
Contributor

Alright, payment summary as follows:

Regression tests for this new feature are being added centrally. Offer sent!

@hoangzinh
Copy link
Contributor

Accepted. Thanks @trjExpensify

@trjExpensify
Copy link
Contributor

Paid!

@github-project-automation github-project-automation bot moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collect May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.
Projects
No open projects
Archived in project
Development

No branches or pull requests

4 participants