[HOLD for payment 2024-05-20] IOU - No bottom margin below the Save button in Merchant page

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Start manual request flow.
4. In confirmation page, click Merchant.

Expected Result:

There will be a bottom margin below the Save button.

Actual Result:

There is no bottom margin below the Save button.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6453280_1713425264720.bottom_margin.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a5cc751dd16f2f72
• Upwork Job ID: 1792647702226952192
• Last Price Increase: 2024-05-20

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @kevinksullivan

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@kevinksullivan I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no bottom margin below the Save button.

What is the root cause of that problem?

We removed the styles.mb5 and styles.mt5 here

https://github.com/Expensify/App/pull/38039/files#diff-88398cd9457f0f27abc859375b1852a0b9a16e3de5da062be27e3ba55c6d02c3

App/src/components/FormAlertWithSubmitButton.tsx

Line 82 in 3ec8f2f

containerStyles={[styles.justifyContentEnd, containerStyles]}

What changes do you think we should make in order to solve the problem?

Add styles.mb5 to containerStyles here.

App/src/components/Form/FormWrapper.tsx

Line 117 in 3ec8f2f

containerStyles={[styles.mh0, styles.mt5, submitFlexEnabled ? styles.flex1 : {}, submitButtonStyles]}

What alternative solutions did you explore? (Optional)

NA

[ghost]

This PR - #38039 caused this issue

[nkuoch]

@lukemorawski Can you make a quick follow up PR for it?

[lukemorawski]

@nkuoch yep, already on it!

[lukemorawski]

Fix PR on it's way

[melvin-bot]

This issue has not been updated in over 15 days. @nkuoch, @kevinksullivan, @allroundexperts, @mountiny, @lukemorawski eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a5cc751dd16f2f72

[melvin-bot]

Current assignee @allroundexperts is eligible for the External assigner, not assigning anyone new.

[mountiny]

This is ready to be paid to @allroundexperts for $250

[melvin-bot]

@nkuoch, @kevinksullivan, @allroundexperts, @mountiny, @lukemorawski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[allroundexperts]

This is good to close!

[JmillsExpensify]

$250 approved for @allroundexperts