[$500] [HOLD for payment 2024-08-19] CRITICAL: Add Pay as Business option for invoices sent to an individual who is admin of their primary workspace

[cristipaval]

Part of the Invoicing V0.3 project

Main issue: https://github.com/Expensify/Expensify/issues/341717
Doc section: Invoicing V1
Project: #vip-billpay

Feature Description

Implement the Pay as business option in the App for the individuals who are admin of their primary workspace. This also includes calling the PayInvoice API command.

Manual Test Steps

Automated Tests

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d3f5acd99a5e211f
• Upwork Job ID: 1825773836120920532
• Last Price Increase: 2024-08-20
• Automatic offers:
• jjcoffee | Reviewer | 103598175

[melvin-bot]

Triggered auto assignment to @kadiealexander (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[kadiealexander]

@cristipaval any updates here?

[cristipaval]

Still held. This is part of Invoicing V0.2. We'll get to this when Invoicing V0.1 is done.

[kadiealexander]

Still on hold! Shifting to monthly while we wait for V2.

[kadiealexander]

No longer on hold!

[kadiealexander]

Actually, still on hold!

[VickyStash]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

[VickyStash]

@shawnborton If I paid the invoice as a business:

1. Should the report preview say that I paid the invoice or should it say that my workspace paid the invoice (ex: viktoryia.kliushun+2 @callstack.com paid or Vik's Workspace paid):
   .

2. Should the invoice report preview avatars be updated to be workspace-to-workspace same way as the room avatars are updated? Same question for all previously/future created invoices in the room?

[VickyStash]

Updates:

• Updated SettlementButton component and IOU.payInvoice method to support paying as a business
• Updated getPayMoneyRequestParams function to change invoice room from B2C to B2B
• Fixed getPrimaryPolicy method

Waiting for some design clarifications to make sure UI looks as expected.

[shawnborton]

Should the report preview say that I paid the invoice or should it say that my workspace paid the invoice (ex: viktoryia.kliushun+2 @callstack.com paid or Vik's Workspace paid):

Good question, I think it would say Workspace paid. We already do this for submitting expenses, when your workspace pays you back and not the individual who approved/paid within the workspace:

Should the invoice report preview avatars be updated to be workspace-to-workspace same way as the room avatars are updated? Same question for all previously/future created invoices in the room?

So are you saying that if the invoice receiver choses to pay via a business bank account, and we update that invoice to be workspace-to-workspace, right? In that case, yes, we should update all of the avatars to reflect the nature of it being workspace-to-workspace.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add Pay as Business option for invoices sent to an individual who is admin of their primary workspace #44970

If no regressions arise, payment will be issued on 2024-08-19. 🎊

For reference, here are some details about the assignees on this issue:

• @VickyStash does not require payment (Contractor)
• @jjcoffee requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jjcoffee] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[jjcoffee]

Regression Test Proposal

1. Login to the app as User A. The user should be the admin of any workspace.
2. Go to FAB -> Select "Send invoice"
3. Send an invoice of any amount to User B (who should be the admin of his primary workspace)
4. Login as User B and open the invoice room from step 3.
5. Tap the Pay button and select Pay as business -> Pay elsewhere
6. Verify that:

• the invoice got paid
• the room is turned into a B2B invoices room, the title and avatars reflect the workspace names and any custom avatars.

7. Login as User A and open the same invoice room. Verify against step 6.

Do we agree 👍 or 👎

[jjcoffee]

@kadiealexander I'd like to request a payment boost here to $500, if possible. There was a large amount of work and time involved in testing and retesting this, and there were essentially two PRs to test as the first got reverted (due I think mostly to this issue that I don't think could reasonably be caught by the reviewer's checklist!). Thanks for the consideration! 🙏

[cristipaval]

Oh yes, @kadiealexander, this is a CRITICAL feature for Invoicing, it definitely qualifies for $500.

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @VickyStash is from an agency-contributor and not due payment
• ROLE: @jjcoffee paid $500

BugZero Checklist (@kadiealexander)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d3f5acd99a5e211f

[melvin-bot]

Current assignee @jjcoffee is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[kadiealexander]

@jjcoffee let me know when you've accepted the offer :)

[melvin-bot]

Upwork job price has been updated to $500

[jjcoffee]

@kadiealexander Thanks Kadie, I've accepted the offer! 🙏

[kadiealexander]

Paid!