[$250] Report - Added content is lost after editing in offline mode and refreshing the page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Send a message in any report
2. Apply offline mode
3. Edit the sent message
4. Refresh the page
5. Change network mode to online

Expected Result:

Added comment while editing in offline mode should persist

Actual Result:

Add comment while editing in offline mode is lost

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6453446_1713434894311.Screen_Recording_2024-04-18_at_adf1.02.28_in_the_afternoon.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bf8721625590c5d0
• Upwork Job ID: 1783009829966831616
• Last Price Increase: 2024-04-24
• Automatic offers:
• Pujan92 | Reviewer | 0
• bernhardoj | Contributor | 0

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[melvin-bot]

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

[JmillsExpensify]

Yikes, this doesn't seem good. I agree that it's #vip-vsb so I will add it to the project. Also going to start with external since that'll be picked up faster.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bf8721625590c5d0

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[Pujan92]

@lanitochka17 I am not able to reproduce it, can you plz check and confirm

Screen.Recording.2024-04-26.at.22.02.14.mov

[lanitochka17]

@Pujan92 Tester is still able to reproduce this issue

Screen.Recording.2024-04-26.at.7.40.11.in.the.evening.mp4

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The edited comment is discarded when refreshing the page while offline.

What is the root cause of that problem?

When we do an API request while offline, we will save it to the networkRequestQueue Onyx so we can process it when we are back online.

App/src/libs/actions/PersistedRequests.ts

Lines 25 to 30 in 777d218

	function save(requestToPersist: Request) {
	persistedRequests.push(requestToPersist);
	Onyx.set(ONYXKEYS.PERSISTED_REQUESTS, persistedRequests).then(() => {
	Log.info(`[SequentialQueue] '${requestToPersist.command}' command queued. Queue length is ${getLength()}`);
	});
	}

However, the queue is never saved because we pass the same instance of the array. You can see in the log that the hasChanged is false.

So, when we refresh the page, the edit request will never be processed, and the OpenReport/ReconnectApp request will return the message data from the BE which is unedited.

What changes do you think we should make in order to solve the problem?

Create a new instance of array before saving the queue.

const requests = [...persistedRequests, requestToPersist];
persistedRequests = requests;
Onyx.set(ONYXKEYS.PERSISTED_REQUESTS, requests)

[melvin-bot]

@JmillsExpensify, @Pujan92 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Pujan92]

I agree with @bernhardoj's RCA and solution as it is not getting updated in the Onyx due to the ref issue. We should assign the new array to the onyx which will do the check correctly for hasValueChanged with 2 different refs.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @Pujan92 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @Pujan92

[Pujan92]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Pujan92] The PR that introduced the bug has been identified. Link to the PR: Remove all request de-duping logic #40180
• [@Pujan92] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/40180/files#r1599450028
• [@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
• [@Pujan92] Determine if we should create a regression test for this bug.: I think no.
• [@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[Pujan92]

Bump @JmillsExpensify for the payment as PR hit the prod a week ago, automation seems broken here.

[JmillsExpensify]

Payment summary:

• Contributor: @bernhardoj $250
• Contributor+: @Pujan92 $250

[JmillsExpensify]

All contracts paid out via Upwork and the BZ checklist is complete. Closing this one out!