[Awaiting checklist] [$250] LHN - LHN disappears upon leaving a public room / back button isn't redirecting to LHN

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.62.17
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR: https://github.com/Expensify/Expensify/issues/318139
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Navigate to https://staging.new.expensify.com/r/8813851443373010
2. Log in with a new Gmail account
3. Leave the room

Or

1. Have a room on some policy
2. Join that room
3. in new tab, deeplink to that room
4. Leave it

Expected Result:

LHN should still be visible.

Actual Result:

LHN disappears upon leaving a public room. It returns if the page is refreshed.
On mWeb, iOS and Android you're unable to use the "<" button to go to the LHN from Concierge after leaving the room.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6456699_1713723474319.LHN.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c4dd40ad35562892
• Upwork Job ID: 1782375600407408640
• Last Price Increase: 2024-04-22

[melvin-bot]

Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@twisterdotcom I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #cvip-vsb.

[izarutskaya]

Production

bandicam.2024-04-22.14-40-01-789.mp4

[twisterdotcom]

Okay, I recreated this here:

40680.mp4

But I have since recreated it on staging with my normal account, doesn't have to be new, or only have 1 other chat in the LHN. Simply put, leaving a room is broken on staging. It removes the LHN AFAIK if the room is left just after joining.

Agree this is a deploy blocker.

[twisterdotcom]

I have no idea why though cc @Beamanator. Maybe this one from @MonilBhavsar? #35671.

Maybe something to do with leaving groups cc @marcaaron?

[twisterdotcom]

Going to make it External to see if we can get a quick fix and some C+ eyes anyway.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c4dd40ad35562892

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[twisterdotcom]

@cubuspl42 would love your help looking for the offending PR here too. Definitely seems like a regression.

[mountiny]

The reproduction steps are a bit esoteric, we need to go and deeplink to the room in new tab, then it sometimes happens when you leave it sometimes it doesnt for me

[MonilBhavsar]

#35671 doesn't seem like a offending PR

[MonilBhavsar]

The reproduction steps are a bit esoteric

I am able to reproduce consistently with -

1. Copy the room url
2. Pasting it and joining the room
3. Leaving the room 💥

[MonilBhavsar]

Okay, while checking if our PR has caused this, I think I found the issue...

[mallenexpensify]

@Pujan92 reassigning, please take over as C+. If you don't have bandwidth, unassign yourself. Thanks
Please review the PR

• Fix LHN breaking when leaving deep linked room #40701

[Pujan92]

@izarutskaya @twisterdotcom Can you plz recheck on staging whether this issue is still reproducible or not

[twisterdotcom]

Nice! It's fixed!

[MonilBhavsar]

I'm able to reproduce this locally with reproduction steps -

1. As an admin create a workspace
2. Add two users A and B to the workspace
3. Login as User A and open policy Expense chat and mention user B and invite them
4. As a user B, open user's B policy expense chat
5. Leave the room and 💥

[MonilBhavsar]

@Pujan92 can you please help here by taking a look. My PR seems to fix this issue

[Pujan92]

Sure @MonilBhavsar, I will try to reproduce with the mentioned steps and will check the PR soon.

[MonilBhavsar]

Thanks! Since the root cause is same. May be the original issue is also still reproducible 😄

[Pujan92]

Able to reproduce sometimes and your PR changes make sense to me. Can you plz reopen it?

Screen.Recording.2024-04-25.at.19.56.17.mov

[MonilBhavsar]

Thanks for confirming! Reopened PR

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix LHN breaking when leaving deep linked room #40701

If no regressions arise, payment will be issued on 2024-05-06. 🎊

For reference, here are some details about the assignees on this issue:

• @Pujan92 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Pujan92] The PR that introduced the bug has been identified. Link to the PR:
• [@Pujan92] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Pujan92] Determine if we should create a regression test for this bug.
• [@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Beamanator]

This looks like it's been ready for payment for a bit @twisterdotcom ? :D

[Pujan92]

Bump @twisterdotcom for the payment if we are not considering the issue #41128 as a regression from here.

[twisterdotcom]

#42073 (comment)

[twisterdotcom]

Payment Summary

Upwork Job

• Reviewer: @Pujan92 paid $250 via Upwork here

[twisterdotcom]

LMK if this needs a regression test.

[Pujan92]

Regression Test Steps

1. Copy any public room URL and signout
2. Visit the copied URL and sign in
3. Leave that public room
4. Verify the LHN isn't disappear