[HOLD for payment 2024-05-22] Bottom button on missing padding

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.64-3
Reproducible in staging?: y
Reproducible in production?: couldn't check
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @Jonvrebdubielzyk
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1713832272368439

Action Performed:

1. Click on Profile photo in botton navigation bar
2. Click on Wallet
3. Under "Assigned cards", click on one of the cards
4. Click on "Report virtual card fraud" or "Report physical card loss / damage"
5. Look at the footer button that has no padding

Expected Result:

On step 5 I would expect the footer button to have correct padding of 20px on both sides and bottom

Actual Result:

On step 5 it didn't have any padding. See screenshots in thread

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bottom button is missing padding on some card related pages.

What is the root cause of that problem?

FormAlertWithSubmitButton doesn't have padding set at the below places.

App/src/pages/settings/Wallet/ReportCardLostPage.tsx

Lines 182 to 189 in 6b18ee9

	<FormAlertWithSubmitButton
	isAlertVisible={shouldShowAddressError}
	onSubmit={handleSubmitSecondStep}
	message="reportCardLostOrDamaged.addressError"
	isLoading={formData?.isLoading}
	buttonText={isDamaged ? translate('reportCardLostOrDamaged.shipNewCardButton') : translate('reportCardLostOrDamaged.deactivateCardButton')}
	/>
	</>

App/src/pages/settings/Wallet/ReportCardLostPage.tsx

Lines 200 to 205 in 6b18ee9

	<FormAlertWithSubmitButton
	isAlertVisible={shouldShowReasonError}
	onSubmit={handleSubmitFirstStep}
	message="reportCardLostOrDamaged.reasonError"
	buttonText={translate('reportCardLostOrDamaged.nextButtonLabel')}
	/>

App/src/pages/settings/Wallet/ReportVirtualCardFraudPage.tsx

Lines 75 to 81 in 6b18ee9

	<FormAlertWithSubmitButton
	isAlertVisible={Boolean(virtualCardError)}
	onSubmit={() => Card.reportVirtualExpensifyCardFraud(virtualCard.cardID)}
	message={virtualCardError}
	isLoading={formData?.isLoading}
	buttonText={translate('reportFraudPage.deactivateCard')}
	/>

App/src/pages/settings/Wallet/TransferBalancePage.tsx

Lines 210 to 221 in 6b18ee9

	<View>
	<FormAlertWithSubmitButton
	buttonText={translate('transferAmountPage.transfer', {
	amount: isTransferable ? CurrencyUtils.convertToDisplayString(transferAmount) : '',
	})}
	isLoading={walletTransfer?.loading}
	onSubmit={() => selectedAccount && PaymentMethods.transferWalletBalance(selectedAccount)}
	isDisabled={isButtonDisabled || isOffline}
	message={errorMessage}
	isAlertVisible={!isEmptyObject(errorMessage)}
	/>
	</View>

What changes do you think we should make in order to solve the problem?

Wrap FormAlertWithSubmitButton inside a View and add styles.mh5, styles.mb5.

Example:

<View style={[styles.mh5, styles.mb5]}>
    <FormAlertWithSubmitButton
        isAlertVisible={Boolean(virtualCardError)}
        onSubmit={() => Card.reportVirtualExpensifyCardFraud(virtualCard.cardID)}
        message={virtualCardError}
        isLoading={formData?.isLoading}
        buttonText={translate('reportFraudPage.deactivateCard')}
    />
</View>

For transfer balance page, View is already there. We just need to add the styles.

In the same way, update at all the mentioned places.

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bottom button on missing padding

What is the root cause of that problem?

We are missing containerStyles in the FormAlertWithSubmitButton the reported pages

App/src/pages/settings/Wallet/ReportCardLostPage.tsx

Line 200 in 6b18ee9

<FormAlertWithSubmitButton

What changes do you think we should make in order to solve the problem?

We will pass styles.mb5 and styles.ph5 as the containerStyles in the reported pages:

App/src/pages/settings/Wallet/ReportCardLostPage.tsx

Line 200 in 6b18ee9

<FormAlertWithSubmitButton

App/src/pages/settings/Wallet/ReportVirtualCardFraudPage.tsx

Line 75 in 6b18ee9

<FormAlertWithSubmitButton

App/src/pages/settings/Wallet/TransferBalancePage.tsx

Line 211 in 6b18ee9

<FormAlertWithSubmitButton

Additionally

The confirm task page also seems to be missing the bottom padding:

Image

We will pass styles.mb5 here:

App/src/pages/tasks/NewTaskPage.tsx

Line 194 in 6b18ee9

containerStyles={[styles.mh0, styles.mt5, styles.flex1, styles.ph5]}

[luacmartins]

@lukemorawski it seems like #38039 caused a regression in a few other places. Could you please take a look at this issue and work on a fix? cc @abdulrahuman5196

[lukemorawski]

@luacmartins sure, though I need to add some fake cards, as I don't have access to those pages now.

[shawnborton]

Another case to consider is the View debug console page:

[shawnborton]

What's the latest on this one?

[MrMuzyk]

I've been asked to take over this issue. I've pushed latest changes to the branch that was previously created and uploaded screenshots with fixed screens

[shawnborton]

Thanks! This regression has been live for a couple of weeks now, so I would love to get this cleaned up ASAP.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.73-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Missing bottom padding fix #40912

If no regressions arise, payment will be issued on 2024-05-22. 🎊

For reference, here are some details about the assignees on this issue:

• @lukemorawski does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins] The PR that introduced the bug has been identified. Link to the PR:
• [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@lukemorawski] Determine if we should create a regression test for this bug.
• [@lukemorawski] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[trjExpensify]

@mollfpr was the C+ on this one! Checklist when you're ready.

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @mollfpr owed $250 via NewDot
• Contributor: @lukemorawski is from an agency-contributor and not due payment

BugZero Checklist (@trjExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[trjExpensify]

Bump for the checklist!

[luacmartins]

@mollfpr could you please complete the checklist?

[trjExpensify]

Melv only listens to me, Carlos.

[mollfpr]

The PR that introduced the bug has been identified. Link to the PR:

#38039

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/38039/files

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

We already have the check when updating a generic component, we should do the test diligently.

Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

I don't think we need to add a new test case here.

[trjExpensify]

Alrighty, thanks. Confirming payment summary as follows:

$250 to @mollfpr for the C+ review. Go ahead and submit an expense.

Closing!