Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hold for payment 2024-05-15] [Polish][QAB] Add GPS data to Scan requests started in the QAB flow. #41098

Closed
Gonals opened this issue Apr 26, 2024 · 11 comments
Closed

[hold for payment 2024-05-15] [Polish][QAB] Add GPS data to Scan requests started in the QAB flow. #41098

Gonals opened this issue Apr 26, 2024 · 11 comments
Assignees
@Pujan92 @Gonals @joekaufmanexpensify
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@Gonals
Copy link
Contributor

Gonals commented Apr 26, 2024 •
edited by melvin-bot bot
Loading

Problem
When creating a Scan Request through the QAB flow, we often skip the final confirmation. In these cases, we do not retrieve/store GPS details in the transaction, like we do for non-QAB cases

Solution
Fix it

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b6583547201ea2ae
  • Upwork Job ID: 1783850550147932160
  • Last Price Increase: 2024-04-26
@Gonals Gonals added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Bug Something is broken. Auto assigns a BugZero manager. labels Apr 26, 2024
@Gonals Gonals self-assigned this Apr 26, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 26, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01b6583547201ea2ae

@Gonals Gonals added the Improvement Item broken or needs improvement. label Apr 26, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 26, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Pujan92 (Internal)

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 26, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Overdue label Apr 29, 2024
@Gonals Gonals added the Reviewing Has a PR in review label Apr 29, 2024
@melvin-bot melvin-bot bot removed the Overdue label Apr 29, 2024
@Gonals Gonals mentioned this issue Apr 29, 2024
Merged
50 tasks
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 29, 2024
@joekaufmanexpensify
Copy link
Contributor

PR in review

@joekaufmanexpensify
Copy link
Contributor

Automation did not work here. PR went to prod last week. Payment due on 2024-05-15

@joekaufmanexpensify joekaufmanexpensify changed the title [Polish][QAB] Add GPS data to Scan requests started in the QAB flow. [hold for payment 2024-05-15] [Polish][QAB] Add GPS data to Scan requests started in the QAB flow. May 13, 2024
@joekaufmanexpensify
Copy link
Contributor

All set to issue payment! Only payment here is $250 to @Pujan92 for C+ review via Upwork

@joekaufmanexpensify
Copy link
Contributor

@Pujan92 offer sent for $250!

@Pujan92
Copy link
Contributor

Pujan92 commented May 16, 2024

Accepted, Thanks @joekaufmanexpensify

@joekaufmanexpensify joekaufmanexpensify added Daily KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 16, 2024
@joekaufmanexpensify
Copy link
Contributor

@Pujan92 $250 sent and contract ended!

@joekaufmanexpensify
Copy link
Contributor

Upwork job closed.

@joekaufmanexpensify
Copy link
Contributor

All set. TY everyone!

@github-project-automation github-project-automation bot moved this from Polish to Done in [#whatsnext] #wave-collect May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pujan92 Pujan92

@Gonals Gonals

@joekaufmanexpensify joekaufmanexpensify

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
No open projects
[#whatsnext] #wave-collect
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Pujan92 @Gonals @joekaufmanexpensify