[HOLD for payment 2024-06-13] [$250] Track - Categorize it - Not here page opens when selecting a workspace with no category

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.67-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Create a new workspace
3. Go to Account settings > Workspaces > workspace in Step 2
4. Go to Categories page
5. Delete all the categories
6. Return to Chat
7. Click FAB > Track expense > Manual
8. Track a manual expense
9. Click Categorize it from the whisper
10. Select the workspace where all categories are deleted

Expected Result:

There should be some error indicating that the workspace has no category other than just a "Not here" page

Actual Result:

Not here page opens when selecting a workspace with no category

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6463645_1714214430640.20240427_183519.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e69ed8db299bc4fe
• Upwork Job ID: 1784791676082184192
• Last Price Increase: 2024-04-29

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[ZhenjaHorbach]

I think this should be fixed in one ticket

#40999

Just in case, my proposition for two issues
#40999 (comment)

[jliexpensify]

Thanks @ZhenjaHorbach - going to assign @mananjadhav as he's the C+ on the other one. Would you like to fold these issues together into one fix?

[mananjadhav]

Yeah we can use the same issue to fix both.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e69ed8db299bc4fe

[melvin-bot]

Current assignee @mananjadhav is eligible for the External assigner, not assigning anyone new.

[jliexpensify]

Ah actually - @mananjadhav what's the best way to handle this? Close this one, and pay in the other issue?

[mananjadhav]

Yes let's close this one and pay in the other issue.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update RequestStepCategory to add Empty and Loading states for category list #41344

If no regressions arise, payment will be issued on 2024-06-13. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: