Incorrect Error is displayed when creating conversation with invalid number

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.67-3
Reproducible in staging?: Yes
Reproducible in production?: Yes

Issue reported by: Applause - Internal Team

Action Performed:

1. Click on FAB > Start Chat
2. Start a chat with the following number - +79585702746
3. Click on the "Search" icon

Expected Result:

An error should display indicating the user there was an error creating the chat.
Header should display the user details. In this case the phone number "+79585702746"
When clicking in search, the conversation with the error should not display.

Actual Result:

An error is displayed indicating the user that "The provided phone number does not match the country you are currently located at, please use your email address instead."
There's a skeleton loader in the header of the conversation.
The conversation with the error is displayed in search.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010c028e1ef30e9a46
• Upwork Job ID: 1785768462241026048
• Last Price Increase: 2024-05-01

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[isagoico]

This was found while reviewing the regression tests for this issue - https://github.com/Expensify/Expensify/issues/390645

This issue #38879 had 2 PRs that fixed the following:

• Skeleton loader - Not fixed - Fix header displays skeleton when creating report with invalid user #39585
• Invalid account is displayed in search - Not fixed - Remove invalid user from contact list #22612

[neonbhai]

The error message is sent from the backend:

We can add the Internal label here

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010c028e1ef30e9a46

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

[sakluger]

I posted in Slack asking for an internal engineer to help.

[sakluger]

Bsed on the discussion, the error from the backend is correct, but we could handle the situation more clearly.

That being said, this is a vary unlikely edge case, I am going to close so we can focus on higher value bugs.