[$250] Taxes settings – The old tax name reappears for a moment if you change it offline.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.68-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4524643
Email or phone of affected tester (no customers): applausetester+jp_e_category@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-internal team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in
3. Create a workspace
4. Click on More features and enable Taxes
5. Add new tax rate
6. Go offline
7. Edit tax rate – change name and rate
8. Go back to taxes setting page
9. Go online and observe edited tax rate

Expected Result:

The new tax name presents if you change it offline

Actual Result:

The old tax name reappears for a moment if you change it offline.
The same with Tags and Categories

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6466174_1714448684274.Tax.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e83b2f5493f8acd6
• Upwork Job ID: 1785239218990989313
• Last Price Increase: 2024-05-07

Issue Owner

Current Issue Owner: @alitoshmatov

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@zanyrenney I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[izarutskaya]

Production

Recording.2410.mp4

[grgia]

Not a deploy blocker

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e83b2f5493f8acd6

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[ph17]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When you change the tax offline and goes back online, the old name reappears for a few seconds until is substituted by the new one

What is the root cause of that problem?

This is an example of the replay effect, as stated in this comment:

App/src/libs/actions/OnyxUpdates.ts

Lines 26 to 30 in 004b3af

	function applyHTTPSOnyxUpdates(request: Request, response: Response) {
	console.debug('[OnyxUpdateManager] Applying https update');
	// For most requests we can immediately update Onyx. For write requests we queue the updates and apply them after the sequential queue has flushed to prevent a replay effect in
	// the UI. See https://github.com/Expensify/App/issues/12775 for more info.
	const updateHandler: (updates: OnyxUpdate[]) => Promise<unknown> = request?.data?.apiRequestType === CONST.API_REQUEST_TYPE.WRITE ? QueuedOnyxUpdates.queueOnyxUpdates : Onyx.update;

The problem is that the first request that applyHTTPSOnyxUpdates receives when the app goes back online is of type read. updateHandler receives Onyx.update which causes the replay effect.

What changes do you think we should make in order to solve the problem?

We should use the same process both for read and write request types. Making udpateHandler receive QueuedOnyxUpdates.queueOnyxUpdates for both cases. For this, we should change the applyHTTPSOnyxUpdates function:

    const isWriteOrReadRequest = request?.data?.apiRequestType === CONST.API_REQUEST_TYPE.WRITE || request?.data?.apiRequestType === CONST.API_REQUEST_TYPE.READ;
    const updateHandler: (updates: OnyxUpdate[]) => Promise<unknown> = isWriteOrReadRequest ? QueuedOnyxUpdates.queueOnyxUpdates : Onyx.update;

[melvin-bot]

📣 @ph17! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[ph17]

Contributor details
Your Expensify account email: pedrohenriquelemos17@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01000c5b7e9dbec144

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[zanyrenney]

@alitoshmatov please can you review the proposal above and let us know if we can move forward with it?

[zanyrenney]

bump @alitoshmatov please can you prioritise this or let us know if we should be finding another C+ to work on this?

[melvin-bot]

@grgia, @zanyrenney, @alitoshmatov Whoops! This issue is 2 days overdue. Let's get this updated quick!

[alitoshmatov]

I couldn't reproduce this issue

Screen.Recording.2024-05-05.at.10.40.59.PM.mov

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@grgia, @zanyrenney, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[zanyrenney]

Let me try and test too.

[zanyrenney]

I can't reproduce this on taxes anymore, its mimicking the expected behaviour offline pattern C.