Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2024-05-01 #41376

Closed
59 tasks done
github-actions bot opened this issue May 1, 2024 · 15 comments
Closed
59 tasks done

Deploy Checklist: New Expensify 2024-05-01 #41376

github-actions bot opened this issue May 1, 2024 · 15 comments
Assignees
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2024

Release Version: 1.4.69-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@francoisl francoisl self-assigned this May 1, 2024
@francoisl francoisl added Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging labels May 1, 2024
@OSBotify
Copy link
Contributor

OSBotify commented May 1, 2024

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.69-0 🚀

@grgia
Copy link
Contributor

grgia commented May 1, 2024

Demoting #41389

@grgia
Copy link
Contributor

grgia commented May 1, 2024

Closed #41387

@francoisl
Copy link
Contributor

francoisl commented May 1, 2024

Demoting #41424
Demoting #41386

@kbecciv
Copy link

kbecciv commented May 1, 2024

TR is 45% left

#37813 - pending verification
#39683 - pending verification
#40388 is failing with #40379, left comment #40388 (comment)
#40402 - pending verification on Desktop and IOS app
#40624 - pending verification on Android and IOS app
#40685 - pending verification on mWeb, Android and IOS app
#41027 is failing with #40535 on Web and Android app, left comment #41027 (comment); it's failing with #41390 on IOS app

Deploy Blockers:
#41386
#41390
#41401
#41410
#41422

@francoisl
Copy link
Contributor

francoisl commented May 1, 2024

@blimpich
Copy link
Contributor

blimpich commented May 1, 2024

Demoting #41434

@kbecciv
Copy link

kbecciv commented May 1, 2024

TR is 17% left

#37813 - pending verification on mWeb, Desktop and IOS app
#39683 is blocked, left comment #39683 (comment)
#40388 is failing with #40379, left comment #40388 (comment)
#40624 is failing with #39673 on Web, mWeb and Desktop -left comment
#41027 is failing with #40535 on Web and Android app, left comment #41027 (comment); it's failing with #41390 on IOS app
#41283 - pending varification

Deploy Blockers:
#41390
#41431

@francoisl
Copy link
Contributor

francoisl commented May 1, 2024

@francoisl
Copy link
Contributor

francoisl commented May 2, 2024

#41283: Checking off as it's under a beta, it will be handled internally
#37813: also under a beta, there were a couple blockers we demoted already - no need to add a blocker for it but it'd be good to keep finishing the test steps to see if any other issue comes up
#39683: this needs to be internal QA, leaving a comment in the PR

@mvtglobally
Copy link

TR is 8% left

#37813 - pending verification on mWeb app

@kbecciv
Copy link

kbecciv commented May 2, 2024

Regression is completed!

Deploy Blocker
#41489

@Beamanator
Copy link
Contributor

#41489 was checked off as not a blocker

@Julesssss
Copy link
Contributor

We have a new Firebase exception, but I am closing it because:

  • This is a single occurrence of low level 'out of memory' crash, which is essentially impossible to resolve
  • There is a single occurance

@Beamanator
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

9 participants