[HOLD for payment 2024-07-10] [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Pay someone flow doesn’t include a reportAction to distinguish the payment method used (Expensify or elsewhere)

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.70-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714729020479179

Action Performed:

Prerequisite: Pay someone with either Expensify or elsewhere option

1. Login as a user who got paid
2. Open the DM and observe the preview for money received
3. Click to open the payment details and observe

Expected Result:

Method of payment displayed in both DM and details page (Expensify or elsewhere)

Actual Result:

Only xyz paid displayed and method of payment not displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014f39f2dacd55f2a4
• Upwork Job ID: 1787959016608243712
• Last Price Increase: 2024-05-21
• Automatic offers:
• ahmedGaber93 | Reviewer | 102528931
• nkdengineer | Contributor | 102528935

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[jainilparikh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Payment type is not mentioned in the details page.

What is the root cause of that problem?

We do not have a field for payment type. We only have fields for 'amount', 'comment', 'merchant', 'date', 'category' and 'tag'.

What changes do you think we should make in order to solve the problem?

Add a new field similar to the one below for 'PaymentType' info:

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 373 to 386 in 951c7b3

	{canUseViolations && <ViolationMessages violations={getViolationsForField('receipt')} />}
	<OfflineWithFeedback pendingAction={getPendingFieldAction('amount')}>
	<MenuItemWithTopDescription
	title={formattedTransactionAmount ? formattedTransactionAmount.toString() : ''}
	shouldShowTitleIcon={isSettled}
	titleIcon={Expensicons.Checkmark}
	description={amountDescription}
	titleStyle={styles.textHeadlineH2}
	interactive={canEditAmount}
	shouldShowRightIcon={canEditAmount}
	onPress={() => Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_AMOUNT.getRoute(CONST.IOU.ACTION.EDIT, iouType, transaction?.transactionID ?? '', report.reportID))}
	brickRoadIndicator={getErrorForField('amount') ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined}
	error={getErrorForField('amount')}
	/>

PaymentType info is available in ParentReportAction array that's passed to this component.

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 90 in 951c7b3

parentReportActions,

What alternative solutions did you explore? (Optional)

[melvin-bot]

@sakluger Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014f39f2dacd55f2a4

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[jainilparikh]

@ahmedGaber93 , the reportAction does not have any information about how payment is done (Via Expensify or via Elsewhere). This is what we get:

avatarUrl: undefined
chatReportID: "8115357106458061"
chatType: ""
currency: "INR"
description: ""
errorFields: []
fieldList:  undefined
invoiceReceiver:  undefined
iouReportID: undefined
isDeletedParentAction: undefined
isOptimisticReport: undefined
isOwnPolicyExpenseChat: false
isPinned: false
isPolicyExpenseChat: undefined
isWaitingOnBankAccount: false
lastMentionedTime: undefined
lastReadTime: "2024-05-12 05:03:17.881"
lastVisibleActionCreated: "2024-05-12 05:03:17.881"
managerID: 16778387
nonReimbursableTotal: 0
notificationPreference: "always"
oldPolicyName: ""
ownerAccountID: 17102600
parentReportActionID: "189825184571791248"
parentReportID: "8115357106458061"
participantAccountIDs: (2) [16778387, 17102600]
pendingFields: undefined
permissions: (2) ['read', 'write']
policyID: "E1269E8555168358"
policyName: undefined
reportID: "7799079344254003"
reportName: "IOU"
stateNum: 2

Do we first need the BE to send this info in the parentReportActions ?

[sakluger]

Not overdue, we're still discussing the expected behavior.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@sakluger, @ahmedGaber93 Huh... This is 4 days overdue. Who can take care of this?

[ahmedGaber93]

I checked it today, we already have the paymentType in FE but not with this reportAction, I will complete checking tomorrow to know if we can catch it from FE, or it requires BE changes

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

@ahmedGaber93 The PR is here.

[johncschuster]

We're waiting on the linked PR above to be merged

[johncschuster]

Still waiting on the linked PR to cross the regression threshold 👍

[johncschuster]

Same as above

[johncschuster]

Same as above

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[johncschuster]

Looks like there was a regression on this one. @stitesExpensify can you see if the linked PR caused the regression?

[stitesExpensify]

Based on the discussion in that issue, tt looks like this PR is the cause, but it might have just needed more as opposed to needing to be reverted etc. @nkdengineer @ahmedGaber93 can you both make sure to keep an eye on that discussion since this did technically cause a regression?

[ahmedGaber93]

The regression case currently in discussion if it should fix or not. And I am 👀 on it.

[nkdengineer]

I checked this issue and I think it's not regression from our PR, because the transaction thread report was hidden in the past.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: display thread of send money request as normal thread #43742

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @ahmedGaber93 requires payment automatic offer (Reviewer)
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ahmedGaber93] The PR that introduced the bug has been identified. Link to the PR:
• [@ahmedGaber93] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ahmedGaber93] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ahmedGaber93] Determine if we should create a regression test for this bug.
• [@ahmedGaber93] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[johncschuster]

Acknowledged! I'll issue payment after the regression window.

[johncschuster]

@ahmedGaber93 can you please complete the BZ Checklist?

[ahmedGaber93]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ahmedGaber93] The PR that introduced the bug has been identified. Link to the PR: N/A. Pay action in send money is not implemented before, so this seems a new requirement
• [@ahmedGaber93] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A.
• [@ahmedGaber93] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A.
• [@ahmedGaber93] Determine if we should create a regression test for this bug. Yes
• [@ahmedGaber93] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Go to a DM and create a send money request
2. Click on report preview to open iou report
3. Verify that a paid system message appears
4. Reply in thread this system message
5. Verify that the thread is displayed as a normal thread

Do we agree 👍 or 👎

[ahmedGaber93]

@johncschuster completed

[johncschuster]

Payment has been issued! Thanks for your contributions!