-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wave Collect][Xero] Display error messages for Xero Import page #41843
Comments
cc @SzymczakJ |
Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue! |
Triggered auto assignment to @bfitzexpensify ( |
Not overdue, progress is still happening. Draft PR to display error messages related to it is here. |
PR hit staging yesterday. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
Assigning @fedirjh as he'll need to be paid for the C+ review of the linked PR once this hits production and the 7 day regression period passes. |
Invited you to an Upwork job @fedirjh |
@bfitzexpensify Thank you. Accepted. |
Problem
We do not display meaningful error messages to the user for the Xero import page.
We only display the RBR indicator.
Solution
Display meaningful error messages to the user, just like we did in
XeroExportConfigurationPage
.Note: you'll need to use the
errorText
property, please see https://github.com/Expensify/App/pull/41670/files#diff-e66a522b9cabb71f5418bb119bae86d49f12cc8f7da039acc4ff3c42991cd25fR29The text was updated successfully, but these errors were encountered: