Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wave Collect][Xero] Display error messages for Xero Import page #41843

Closed
lakchote opened this issue May 8, 2024 · 9 comments
Closed

[Wave Collect][Xero] Display error messages for Xero Import page #41843

lakchote opened this issue May 8, 2024 · 9 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@lakchote
Copy link
Contributor

lakchote commented May 8, 2024

Problem

We do not display meaningful error messages to the user for the Xero import page.

We only display the RBR indicator.

Solution

Display meaningful error messages to the user, just like we did in XeroExportConfigurationPage.

Note: you'll need to use the errorText property, please see https://github.com/Expensify/App/pull/41670/files#diff-e66a522b9cabb71f5418bb119bae86d49f12cc8f7da039acc4ff3c42991cd25fR29

@lakchote lakchote self-assigned this May 8, 2024
@lakchote
Copy link
Contributor Author

lakchote commented May 8, 2024

cc @SzymczakJ

@SzymczakJ
Copy link
Contributor

Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue!

@trjExpensify trjExpensify added the Bug Something is broken. Auto assigns a BugZero manager. label May 9, 2024
Copy link

melvin-bot bot commented May 9, 2024

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lakchote
Copy link
Contributor Author

Not overdue, progress is still happening. Draft PR to display error messages related to it is here.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Daily KSv2 labels May 13, 2024
@trjExpensify
Copy link
Contributor

trjExpensify commented May 16, 2024

PR hit staging yesterday.

Copy link

melvin-bot bot commented May 16, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@lakchote
Copy link
Contributor Author

Assigning @fedirjh as he'll need to be paid for the C+ review of the linked PR once this hits production and the 7 day regression period passes.

@bfitzexpensify
Copy link
Contributor

Invited you to an Upwork job @fedirjh

@fedirjh
Copy link
Contributor

fedirjh commented May 31, 2024

@bfitzexpensify Thank you. Accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

5 participants