Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU - A dot appears at the end of the currency for SOS and BTN #4208

Closed
5 tasks done
kavimuru opened this issue Jul 24, 2021 · 4 comments
Closed
5 tasks done

IOU - A dot appears at the end of the currency for SOS and BTN #4208

kavimuru opened this issue Jul 24, 2021 · 4 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Jul 24, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.new.expensify.com
  2. Log in with any account
  3. Click on Plus Green button
  4. Click Request
  5. Tap/click on the currency
  6. Use the search function in the currency list and select a currency.
  7. Search for SOS and BTN

Expected Result:

Currencies should listed without point at the end.

Actual Result:

There are two currencies listed with point at the end.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number:
1.0.80-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:

View all open jobs on Upwork

@MelvinBot
Copy link

Triggered auto assignment to @HorusGoul (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@isagoico isagoico changed the title mWeb - IOU - A dot appears at the end of the currency for SOS and BTN IOU - A dot appears at the end of the currency for SOS and BTN Jul 24, 2021
@isagoico
Copy link

Not sure if this is a deploy blocker or expected 🤔 These currencies are not displayed in production, I'll add the DB label so it's reviewed CC @andrew

@isagoico isagoico added the DeployBlockerCash This issue or pull request should block deployment label Jul 24, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels Jul 24, 2021
@HorusGoul
Copy link
Contributor

The official symbols for these currencies include the dots, so I'm gonna close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants