[Hold #43508] Workspace - "Hidden" members appear in the list when a member leaves

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.75-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #41492

Action Performed:

1. Admin: Log in as a new expensifail user
2. Member: Log in as a new Gmail user in a different device
3. Admin: Create a workspace
4. Admin: Invite the member to the workspace
5. Admin: Navigate to the Workspace member list page
6. Admin: Open the member details page
7. Member: Leave the workspace
8. Admin: Click on "Go back to home page"

Expected Result:

Only real members of the workspace should be shown

Actual Result:

"Hidden" members appear in the list when a workspace member leaves

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6489324_1716464062492.bandicam_2024-05-23_13-29-15-740.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[trjExpensify]

Commented on the issue the PR is attached to. CC: @alitoshmatov @tienifr @madmax330

[tienifr]

@trjExpensify Hi, I took a look, this is not a regresison from that PR because reverting it does not solve the issue.

This is a BE problem. I notice that when the employee left the workspace, the Pusher sent to admin a very strange policy.employeeList value:

employeeList is supposed to be a object mapping from an user's login to his details, but in this case, it's r032022+8626@gmail.com which is a part of the employee's login (tienifr032022+8626@gmail.com). I hope this helps with the debugging in BE.

[trjExpensify]

Asking in #vip-vsb about the intent with this Leave functionality.

[melvin-bot]

@trjExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[trjExpensify]

Didn't link the thread where we're discussing.

[trjExpensify]

Alright, so looks like this was missed. Members should be able to leave a workspace unless they're under domain control on both NewDot and OldDot.

This issue provides a bit of history on why that wasn't the case with a helpful comment from @iwiznia. That said, a lot has changed since then and Auth is aware of the employeeList now. 👍

Sending Internal.

[melvin-bot]

@trjExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[trjExpensify]

Waiting to be picked up in hot picks.

[melvin-bot]

@trjExpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[trjExpensify]

No change.

[trjExpensify]

@Beamanator with the approvals work and behaviour around leaving a workspace, will this be cleaned up? I think it's somewhat linked to this weird dynamic of allowing someone to "leave" workspace on NewDot but not properly handled on the backend, as you can't do that on OldDot.

[trjExpensify]

Put this on hold for #43508

[trjExpensify]

Still held, Melv.

[trjExpensify]

No change.

[trjExpensify]

We're still held.

[trjExpensify]

Still holding.

[trjExpensify]

Still held.

[trjExpensify]

No change, still held.

[trjExpensify]

Still held. I'm dropping to monthly until there's traction on the other.