Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] App performance - Laggy transition when switching from one report to another #42654

Closed
6 tasks done
lanitochka17 opened this issue May 27, 2024 · 14 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2 Reviewing Has a PR in review

Comments

@lanitochka17
Copy link

lanitochka17 commented May 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.76-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Open a report from LHN
  3. Open another report from LHN
  4. Note that transition when switching from one report to another

Expected Result:

The transition when switching from one report to another will not be laggy (production behavior)

Actual Result:

The transition when switching from one report to another is laggy
The entire app on all platforms is slow. The reproduction steps are just one of the ways to show the lagginess

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6493108_1716828480619.20240528_004526.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0183ab1dc4a4be8fe5
  • Upwork Job ID: 1795451622908186624
  • Last Price Increase: 2024-05-28
Issue OwnerCurrent Issue Owner: @akinwale
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels May 27, 2024
Copy link

melvin-bot bot commented May 27, 2024

Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 27, 2024

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label May 27, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 27, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@strepanier03 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label May 28, 2024
Copy link

melvin-bot bot commented May 28, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0183ab1dc4a4be8fe5

@melvin-bot melvin-bot bot changed the title App performance - Laggy transition when switching from one report to another [$250] App performance - Laggy transition when switching from one report to another May 28, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 28, 2024
Copy link

melvin-bot bot commented May 28, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

@mountiny
Copy link
Contributor

Making this external but also asked the agencies to look into this one closely https://expensify.slack.com/archives/C05LX9D6E07/p1716902910273389

@mountiny mountiny removed the DeployBlocker Indicates it should block deploying the API label May 28, 2024
@mountiny
Copy link
Contributor

@kirillzyusko has got some good investigation going on in the thread

@kavimuru
Copy link

Retested in https://42725.pr-testing.expensify.com/r (web / mweb) and in the android adhoc build https://ad-hoc-expensify-cash.s3.amazonaws.com/android/42725/index.html . It was a pass. Tester does not have access to iOS ad hoc build

Screen_Recording_20240529_093803_New.Expensify.AdHoc.mp4
20240529_093241.mp4

@Beamanator
Copy link
Contributor

Beamanator commented May 29, 2024

Merged revert PR #42725 to fix this for now, to unblock deploy

@Beamanator Beamanator removed DeployBlockerCash This issue or pull request should block deployment Help Wanted Apply this label when an issue is open to proposals by contributors labels May 29, 2024
@Beamanator
Copy link
Contributor

PR CP'd and working well in staging, not a blocker anymore 👍

Copy link

melvin-bot bot commented Jun 21, 2024

This issue has not been updated in over 15 days. @akinwale, @strepanier03, @chiragsalian eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@mountiny
Copy link
Contributor

I think this can be closed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants