[HOLD for payment 2024-06-11] [HOLD for payment 2024-06-06] Distance - Map preview shows "Map pending" instead of map on confirmation page and editor

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.76-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• App location permission is disabled

1. Go to staging.new.expensify.com
2. Go to FAB > Submit expense > Distance
3. Enter waypoints > Next
4. Select a workspace > Next
5. Submit the expense
6. Click on the preview
7. Click on the preview again
8. Click Distance

Expected Result:

In Step 4, map preview will appear on confirmation page
In Step 6, "Map pending" element will not appear outside the expense preview
In Step 8, map preview will appear on distance editor

Actual Result:

In Step 4, map preview shows "Map pending" on confirmation page
In Step 6, "Map pending" element appears outside the expense preview
In Step 8, map preview shows "Map pending" on distance editor

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6494993_1716979768020.missing_map_preview.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@grgia FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[grgia]

Hmm I think there's an issue with creating distance requests I noticed some tests were failing on a PR I was working on

[tienifr]

Seems related to my PR #42509. Taking a look.

[grgia]

Im unable to replicate, thanks for jumping in @tienifr - let me know if you find anything

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[tienifr]

I'll push fix PR in several minutes.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: pending map in IOU confirmation step #42773

If no regressions arise, payment will be issued on 2024-06-06. 🎊

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: pending map in IOU confirmation step #42773

If no regressions arise, payment will be issued on 2024-06-11. 🎊

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[melvin-bot]

@grgia Eep! 4 days overdue now. Issues have feelings too...