Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distance - Missing tax rate and tax amount rows on confirmation page #42763

Closed
6 tasks done
kbecciv opened this issue May 29, 2024 · 7 comments
Closed
6 tasks done

Distance - Missing tax rate and tax amount rows on confirmation page #42763

kbecciv opened this issue May 29, 2024 · 7 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented May 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.76-0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #42342
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • Workspace is tax-enabled.
  1. Go to staging.new.expensify.com
  2. Go to FAB > Submit expense > Distance.
  3. Enter waypoints > Next.
  4. Select a workspace > Next.

Expected Result:

Tax rate and tax amount rows will be present on confirmation page (production behavior).

Actual Result:

Tax rate and tax amount rows are missing on confirmation page.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6495095_1716987204851.bandicam_2024-05-29_20-48-53-937.mp4

View all open jobs on GitHub

@kbecciv kbecciv added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels May 29, 2024
Copy link

melvin-bot bot commented May 29, 2024

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@kbecciv
Copy link
Author

kbecciv commented May 29, 2024

We think that this bug might be related to #vip-vsb

@trjExpensify
Copy link
Contributor

@kbecciv I can't tell from the video, did they enable track tax on distance on the workspace in OldDot or not?

@MonilBhavsar MonilBhavsar removed the DeployBlocker Indicates it should block deploying the API label May 29, 2024
@MonilBhavsar
Copy link
Contributor

This is not a Web-E blocker at least, so removing label

@kbecciv
Copy link
Author

kbecciv commented May 29, 2024

It's working if user enabled the track tax on distance on the workspace in OldDot.

20240529_221006.mp4

@trjExpensify
Copy link
Contributor

Nice! So that's expected, and we can close this as not a deploy blocker.

@MonilBhavsar MonilBhavsar removed the DeployBlockerCash This issue or pull request should block deployment label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants