App is crashing when loading contacts / user list

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app and login as expensifail account
2. Tap on search icon

Expected Result:

User is brought to search screen

Actual Result:

App will crash every time search icon is tapped. Same is happening when requesting money and creating new chat/group

Workaround:

No workaround found

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.0.81-2

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation
iOS crash logs
Android Crash Logs

Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @Luke9389 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[isagoico]

There's also a weird behaviour in Web with the contact list. It's showing only a few users and there's this console error

Uncaught TypeError: e.props.onLayout is not a function
    at Object.onViewableItemsChanged (OptionsList.js:247)
    at r._onViewableItemsChanged (index.js:105)
    at e.t._onUpdateSync (index.js:222)
    at e.t.onUpdate (index.js:161)
    at index.js:1330
    at Array.forEach (<anonymous>)
    at n.t._updateViewableItems (index.js:1329)
    at n.r._updateCellsToRender (index.js:584)
    at n.t._scheduleCellsToRenderUpdate (index.js:1315)
    at r._onLayout (index.js:411)

[Jag96]

cc @marcaaron looks like this is related to https://github.com/Expensify/App/pull/4247/files#diff-6a3f4819485fb409e83240f58a2b8ee3c096ad40718d8f9e12929c1adb888a38R247

[mananjadhav]

Yeah, it is because we've defined onLayout: undefined

Fix: Replace undefined with onLayout: () => {}

[trjExpensify]

We think this is also the source of the crash when tapping New Chat or New Group, as well as when you tap next on IOUAmount to try and move on to the IOUParticipants page.

Can we retest those flows with the fix?

[marcaaron]

Sure @trjExpensify added a note to the fix PR. Thanks for the help everyone!

[Jag96]

Fix has been deployed to staging, closing