Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to remove users/ user from the Workplace #4299

Closed
1 of 5 tasks
isagoico opened this issue Jul 29, 2021 · 4 comments
Closed
1 of 5 tasks

Unable to remove users/ user from the Workplace #4299

isagoico opened this issue Jul 29, 2021 · 4 comments
Assignees
Labels
Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@isagoico
Copy link

isagoico commented Jul 29, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app
  2. Click on FAB menu
  3. New Workspace
  4. Click on Get Started!
  5. Select People
  6. Invite 3 users to your workspace
  7. Select one of the users/ user and Click Remove
  8. Click Remove button on the Remove Members popup

Expected Result:

Able to remove users/ user from the Workplace

Actual Result:

Unable to remove users/ user from the Workplace

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.0.81-1

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Bug5171761_Image_from_iOS__5_.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

@MelvinBot
Copy link

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Jag96
Copy link
Contributor

Jag96 commented Jul 30, 2021

I can reproduce this one, the error being returned from the API is Invalid email address parameter because for some reason the emailList value is an empty string when sending from iOS but not from web. We're currently sending an array of strings to the API, but in the Web repo for the same command we send a comma-separated list of emails. The API expects a comma-separated list as well, so I'll make a PR to send a comma-separated list to the API instead of an array.

@Jag96 Jag96 assigned Jag96 and unassigned johnmlee101 Jul 30, 2021
@Jag96 Jag96 added the Reviewing Has a PR in review label Jul 30, 2021
@MelvinBot
Copy link

@Jag96 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@Jag96
Copy link
Contributor

Jag96 commented Aug 6, 2021

This has the reviewing label so Melvin shouldn't be pinging, but also this is on production so closing

@Jag96 Jag96 closed this as completed Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

4 participants