Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android & iOS - Profile - Default avatar is small when viewed in full screen #43050

Closed
2 of 6 tasks
m-natarajan opened this issue Jun 4, 2024 · 11 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.79-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Launch New Expensify app.
  2. Go to any chat.
  3. Tap on the chat header.
  4. Tap on the user avatar.

Expected Result:

User avatar will not appear small when viewed in full screen.

Actual Result:

User avatar is small when viewed in full screen.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6501800_1717519658236.Screen_Recording_20240605_004544_New_Expensify.mp4

View all open jobs on GitHub

@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jun 4, 2024
Copy link

melvin-bot bot commented Jun 4, 2024

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jun 4, 2024

Triggered auto assignment to @bondydaa (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jun 4, 2024
Copy link
Contributor

github-actions bot commented Jun 4, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

@bondydaa FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@m-natarajan
Copy link
Author

We think that this bug might be related to #vip-vsb

@neil-marcellini neil-marcellini removed the DeployBlocker Indicates it should block deploying the API label Jun 4, 2024
@neil-marcellini
Copy link
Contributor

I'm 90% sure this is not a backend deploy blocker

@bernhardoj
Copy link
Contributor

It's from #42174 where we don't scale the image to fit the screen anymore (except bigger image than the screen).

@bondydaa
Copy link
Contributor

bondydaa commented Jun 5, 2024

cc @samilabud @arosiclair @eVoloshchak can you take a look and confirm if this was from your PR?

@samilabud
Copy link
Contributor

cc @samilabud @arosiclair @eVoloshchak can you take a look and confirm if this was from your PR?

Confirmed!

what should the expected behavior? most of the time images that are smaller than the container are pixelated, hence the origin of the change.

@arosiclair
Copy link
Contributor

This should be expected behavior now. We're no longer scaling up small images automatically (you can still pinch to zoom though).

@bondydaa bondydaa removed the DeployBlockerCash This issue or pull request should block deployment label Jun 5, 2024
@bondydaa
Copy link
Contributor

bondydaa commented Jun 5, 2024

ah coolio @m-natarajan please make a note this is now expected behavior.

@bondydaa bondydaa closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants