[HOLD for payment 2024-08-19] [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Thread - App shows not here page when clicking on blue "Thread" in thread view

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.80-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Create a manual expense
4. Click on the expense preview to go to expense report
5. Send a message
6. Open the message in thread
7. Click on the blue "Thread" above the parent message

Expected Result:

App will return to the main chat

Actual Result:

App shows not here page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6503923_1717681058420.RPReplay_Final1717680725.1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@Julesssss FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[Julesssss]

I can reproduce. We seem to get stuck in a loop infinitely calling OpenReport and GetOlderActions

[Julesssss]

Actually, this isn't always reproducible. Sometimes it does work. Here are some potentially related issues that I will comment on:

• Fix LHN shows Not found when navigated from global create menu or report parent navigation link #43086
• Fix get all ancestors in a thread #42554
• Fix report total and alignment #42932
• Group chat cleanup #43027

[luacmartins]

@Julesssss I tried to revert #43086, but it did not solve the issue

[luacmartins]

Reverting #42554 seems to fix it for me

[luacmartins]

Here's the revert PR if we decide to revert it

[luacmartins]

That link seems unrelated to this issue

[ikevin127]

My bad, I mistaken the link / issue.

I posted the same thing here yesterday: margelo#20 (comment) thinking it's caused by that PR which is not merged yet, therefore confirming that the issue wasn't present yeaterday on staging (at time of testing).

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[kmbcook]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Thread - App shows not here page when clicking on blue "Thread" in thread view

What is the root cause of that problem?

The root cause stems from #34640 where ReportUtils.getAllAncestorReportActions was originally written. We now know this because fixing that root cause in #42554 causes this regression. See #41519 (comment) for details.

What changes do you think we should make in order to solve the problem?

Address the root cause by using the correct ancestor reportID, instead of leaving the root cause in place and reverting #42554.

[Julesssss]

Should be fixed with this revert

[kmbcook]

This is a duplicate of #43190. See my proposal there.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Fix get all ancestors in a thread" #43201

If no regressions arise, payment will be issued on 2024-06-18. 🎊

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Fix get all ancestors in a thread" #43201

If no regressions arise, payment will be issued on 2024-06-20. 🎊

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[luacmartins]

I think we can close this since we fixed it with a revert and it was all done internally

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Fix get all ancestors in a thread" #43201

If no regressions arise, payment will be issued on 2024-08-19. 🎊