Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Workspace switcher - Expensify and workspace are highlighted when navigating by keyboard #43296

Closed
2 of 6 tasks
m-natarajan opened this issue Jun 7, 2024 · 13 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Hourly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Jun 7, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.80-9
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition:

  • User has at least one workspace.
  • Workspace switcher is set to "Expensify".
  1. Go to staging.new.expensify.com
  2. Open workspace switcher.
  3. Navigate through the workspace list via keyboard.

Expected Result:

"Expensify" filter will not be highlighted when navigating through the workspace list via keyboard.

Actual Result:

Both "Expensify" and the selected workspace are highlighted when navigating through the workspace list via keyboard.
User is also unable to move the selection from workspace list to Expensify and vice versa.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6505059_1717768746773.bandicam_2024-06-07_21-55-06-743.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0120bd99e26c1b69ef
  • Upwork Job ID: 1799087109849632061
  • Last Price Increase: 2024-06-07
Issue OwnerCurrent Issue Owner: @rojiphil
@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jun 7, 2024
Copy link

melvin-bot bot commented Jun 7, 2024

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jun 7, 2024

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jun 7, 2024
Copy link
Contributor

github-actions bot commented Jun 7, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

@tgolen FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@m-natarajan
Copy link
Author

We think that this bug might be related to #vip-vsb

@isabelastisser isabelastisser added External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Jun 7, 2024
@melvin-bot melvin-bot bot changed the title Workspace switcher - Expensify and workspace are highlighted when navigating by keyboard [$250] Workspace switcher - Expensify and workspace are highlighted when navigating by keyboard Jun 7, 2024
Copy link

melvin-bot bot commented Jun 7, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0120bd99e26c1b69ef

Copy link

melvin-bot bot commented Jun 7, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

@cretadn22
Copy link
Contributor

The offending PR

@Krishna2323
Copy link
Contributor

We separated Expensify option and selection list, before that Expensify option was in the list so it was only highlighted when focused. This is expected behaviour IMO.

cc: @blimpich @getusha

@getusha
Copy link
Contributor

getusha commented Jun 7, 2024

We separated Expensify option and selection list, before that Expensify option was in the list so it was only highlighted when focused. This is expected behaviour IMO.

I agree, wdyt @blimpich?

@blimpich
Copy link
Contributor

blimpich commented Jun 7, 2024

Yeah seems like intended behavior to me. And even if it isn't we shouldn't block the deploy over this.

@blimpich blimpich removed DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Jun 7, 2024
@blimpich
Copy link
Contributor

blimpich commented Jun 7, 2024

Asked internally to double check if this is intended behavior. If people agree lets close this.

@blimpich
Copy link
Contributor

Closing as this is intended behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Hourly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

8 participants