Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-24] [#Wave-Control - Add Sage Intacct] Settings Configuration in NewDot: Export #43534

Closed
yuwenmemon opened this issue Jun 12, 2024 · 31 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Weekly KSv2

Comments

@yuwenmemon
Copy link
Contributor

yuwenmemon commented Jun 12, 2024

Tracking GH: https://github.com/Expensify/Expensify/issues/388780

Design doc section: https://docs.google.com/document/d/1k3ZFw8KB55yPUSCG6KYZlwpwEtmRt3eUshwxs7bZq5I/edit#heading=h.vn04szhrriv7


You will find in the following issue the pseudocode for the different flows. Use them as a guide in your implementation.

Export flow

Main page

function SageIntacctExportPage({policy}: WithPolicyProps) {
    const {export: exportConfig, pendingFields, errorFields} = policy?.connections?.intacct?.config ?? {};

    const currentSageIntacctOrganizationName = useMemo(() => getCurrentSageIntacctOrganizationName(policy ?? undefined), [policy]);

    const sections = useMemo(
        () => [
            {
                description: translate('workspace.sageIntacct.preferredExporter'),
                action: () => Navigation.navigate(ROUTES.POLICY_ACCOUNTING_SAGE_INTACCT_PREFERRED_EXPORTER.getRoute(policyID)),
                title: exportConfig.exporter || translate('workspace.sageIntacct.notConfigured'),
                hasError: !!errorFields?.export.exporter,
                pendingAction: pendingFields?.export.exporter,
            },
            {
                description: translate('workspace.sageIntacct.exportDate'),
                action: () => Navigation.navigate(ROUTES.POLICY_ACCOUNTING_SAGE_INTACCT_EXPORT_DATE.getRoute(policyID)),
                title: translate('workspace.sageIntacct.exportDate'),
                hasError: !!errorFields?.export.exportDate,
                pendingAction: pendingFields?.export.exportDate,
            },
            {
                description: translate('workspace.sageIntacct.exportReimbursableExpensesAs'),
                action: () => Navigation.navigate(ROUTES.POLICY_ACCOUNTING_SAGE_INTACCT_REIMBURSABLE_EXPENSES.getRoute(policyID)),
                title: exportConfig.reimbursable ? translate(`workspace.accounting.reimbursable.${exportConfig.reimbursable}`) : translate('workspace.sageIntacct.notConfigured'),
                hasError: !!errorFields?.export.reimbursable,
                pendingAction: pendingFields?.export.reimbursable,
            },
            {
                description: translate('workspace.sageIntacct.exportNonReimbursableExpensesAs'),
                action: () => Navigation.navigate(ROUTES.POLICY_ACCOUNTING_SAGE_INTACCT_NON_REIMBURSABLE_EXPENSES.getRoute(policyID)),
                title: exportConfig.nonReimbursable ? translate(`workspace.accounting.nonReimbursable.${exportConfig.nonReimbursable}`) : translate('workspace.sageIntacct.notConfigured'),
                hasError: !!errorFields?.export.nonReimbursable,
                pendingAction: pendingFields?.export.nonReimbursable,
            },
        ],
        [
		//... useMemo() dependencies
        ],
    );

    return (
        <ConnectionLayout
            displayName={SageIntacctExportPage.displayName}
            headerTitle="workspace.accounting.export"
            headerSubtitle={currentSageIntacctOrganizationName}
            accessVariants={[CONST.POLICY.ACCESS_VARIANTS.ADMIN, CONST.POLICY.ACCESS_VARIANTS.PAID]}
            policyID={policyID}
            featureName={CONST.POLICY.MORE_FEATURES.ARE_CONNECTIONS_ENABLED}
            contentContainerStyle={styles.pb2}
            titleStyle={styles.ph5}
            connectionName={CONST.POLICY.CONNECTIONS.NAME.SAGE_INTACCT}
        >
	                <Text style={[styles.ph5, styles.pb5]}>{translate('workspace.sageIntacct.exportDescription')}</Text>
            {sections.map((section) => (
                <OfflineWithFeedback key={section.description} pendingAction={section.pendingAction}>
                    <MenuItemWithTopDescription
                        title={section.title}
                        description={section.description}
                        shouldShowRightIcon
                        onPress={section.action}
                        brickRoadIndicator={section.hasError ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined}
                    />
                </OfflineWithFeedback>
            ))}
        </ConnectionLayout>
    );
}

SageIntacctExportPage.displayName = 'PolicySageIntacctExportPage';

export default withPolicy(SageIntacctExportPage);
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017260ab59e4fe16a6
  • Upwork Job ID: 1800760782833912827
  • Last Price Increase: 2024-06-12
  • Automatic offers:
    • hungvu193 | Contributor | 102699116
Issue OwnerCurrent Issue Owner: @puneetlath
@yuwenmemon yuwenmemon self-assigned this Jun 12, 2024
@yuwenmemon yuwenmemon added Weekly KSv2 Daily KSv2 NewFeature Something to build that is a new item. External Added to denote the issue can be worked on by a contributor and removed Weekly KSv2 labels Jun 12, 2024
Copy link

melvin-bot bot commented Jun 12, 2024

Triggered auto assignment to @puneetlath (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jun 12, 2024
Copy link

melvin-bot bot commented Jun 12, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

@melvin-bot melvin-bot bot changed the title [#Wave-Control - Add Sage Intacct] Settings Configuration in NewDot: Export [$250] [#Wave-Control - Add Sage Intacct] Settings Configuration in NewDot: Export Jun 12, 2024
Copy link

melvin-bot bot commented Jun 12, 2024

Job added to Upwork: https://www.upwork.com/jobs/~017260ab59e4fe16a6

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 12, 2024
Copy link

melvin-bot bot commented Jun 12, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 12, 2024
Copy link

melvin-bot bot commented Jun 12, 2024

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

@yuwenmemon yuwenmemon changed the title [$250] [#Wave-Control - Add Sage Intacct] Settings Configuration in NewDot: Export [#Wave-Control - Add Sage Intacct] Settings Configuration in NewDot: Export Jun 12, 2024
@yuwenmemon yuwenmemon added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Jun 12, 2024
@melvin-bot melvin-bot bot changed the title [#Wave-Control - Add Sage Intacct] Settings Configuration in NewDot: Export [$250] [#Wave-Control - Add Sage Intacct] Settings Configuration in NewDot: Export Jun 12, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 12, 2024
Copy link

melvin-bot bot commented Jun 12, 2024

Current assignee @s77rt is eligible for the External assigner, not assigning anyone new.

@yuwenmemon yuwenmemon changed the title [$250] [#Wave-Control - Add Sage Intacct] Settings Configuration in NewDot: Export [#Wave-Control - Add Sage Intacct] Settings Configuration in NewDot: Export Jun 12, 2024
@yuwenmemon yuwenmemon removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 12, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 24, 2024
@hungvu193
Copy link
Contributor

I think @yuwenmemon or @NikkiWines can give you the BE update 👀

@melvin-bot melvin-bot bot removed the Overdue label Jun 24, 2024
@hungvu193
Copy link
Contributor

I think PR is ready but I'm waiting for backend to test it throughly. @hungvu193 are there any updates on the backend PR for the export page? 👀

Did you get the answer via slack?

@war-in
Copy link
Contributor

war-in commented Jun 28, 2024

@hungvu193 Yes! All questions were answered :)
tl;dr
Backend for export is almost ready (or ready). I'll check that soon

@hungvu193
Copy link
Contributor

Awesome :)

@yuwenmemon
Copy link
Contributor Author

Just merged the Export APIs they should be on staging on Monday

@hungvu193
Copy link
Contributor

PR will be ready for review today.

@war-in
Copy link
Contributor

war-in commented Jul 1, 2024

@hungvu193 I think we should split my export PR because it grows quickly (it's over 1000 lines already).
I suggest adding offline and error states in a followup PR (I'll start working on it soon).

Please share your thoughts here 🙏

@hungvu193
Copy link
Contributor

@hungvu193 I think we should split my export PR because it grows quickly (it's over 1000 lines already).

I suggest adding offline and error states in a followup PR (I'll start working on it soon).

Please share your thoughts here 🙏

Yes please go ahead 😁. Totally agree with you

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jul 1, 2024
@war-in
Copy link
Contributor

war-in commented Jul 3, 2024

Update:

@hungvu193
Copy link
Contributor

I'd suggest we should merge #43776 first then test the API and other stuff in a follow PR (#44739)

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 4, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 17, 2024
@melvin-bot melvin-bot bot changed the title [#Wave-Control - Add Sage Intacct] Settings Configuration in NewDot: Export [HOLD for payment 2024-07-24] [#Wave-Control - Add Sage Intacct] Settings Configuration in NewDot: Export Jul 17, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 17, 2024
Copy link

melvin-bot bot commented Jul 17, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jul 17, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jul 17, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@hungvu193] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@hungvu193
Copy link
Contributor

No payment needed for me here. Feel free to close this one.

@puneetlath
Copy link
Contributor

Got it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Weekly KSv2
Projects
Archived in project
Development

No branches or pull requests

7 participants