[HOLD for payment 2024-07-10] [LOW] [Performance] Fix onyx mocking for reassure

[mountiny]

After updating Onyx to a later version here: #42772, the mocking for Onyx has to be updated in the reassure tests, as otherwise, they will fail.

We have disabled the tests after confirming the regressions are not manifesting in the product.

Discussing in this slack thread. Let's figure out how to fix the onyx mocking and update the tests with it cc @chrispader @OlimpiaZurek

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[OlimpiaZurek]

Hi. I'm Olimpia from Callstack. I would like to work on this issue.

[mountiny]

Thanks

[OlimpiaZurek]

Daily Update: It looks like the issue with increasing render count after removing null values from the cache in onyx is likely due to more frequent state updates and re-renders. The Jest environment makes things worse by handling mocks, asynchronous operations, and state updates differently than in a real application, leading to excessive rendering.

I have found that simplifying the tests by breaking the scenarios into smaller parts and testing the performance of smaller pieces of the component could solve this problem. This will ensure that each part of the scenario addresses specific state updates, making it easier to manage and understand the impact of each update on component render counts.

So the next step is to change these tests according to the above conclusions. I should have my PR ready at the beginning of next week.

[laurenreidexpensify]

@OlimpiaZurek still on track to get a PR up in next day?

[OlimpiaZurek]

I've been working on a different task recently. I'll come back to this tomorrow. The PR should be ready by Wednesday.

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[laurenreidexpensify]

@kadiealexander handing over in prep for parental leave 🙏 this one is still waiting on getting a PR up, but Olimpia should have this done today 👍

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NOQA] Fix Reassure test after updating Onyx #44004
• [NOQA] fix Reassure test for ReportScreen #44282

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @OlimpiaZurek does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@OlimpiaZurek] Determine if we should create a regression test for this bug.
• [@OlimpiaZurek] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

I believe this is now completed and we do not have anything else actionable.

Thank you @OlimpiaZurek