Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-20] [$250] Mark down - Copying and pasting part of a code block doesn't work #43551

Closed
1 of 6 tasks
izarutskaya opened this issue Jun 12, 2024 · 20 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@izarutskaya
Copy link

izarutskaya commented Jun 12, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.82-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Open any chat report
  3. Send a code block using opening three back ticks and closing three back ticks at the end
  4. Select part of the sent code block and press ctrl + c to copy and paste it on the compose box

Expected Result:

The copied code block is pasted

Actual Result:

Nothing gets pasted in the compose box

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6510462_1718180975471.bandicam_2024-06-12_11-25-03-468.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bd2b97089b315a6c
  • Upwork Job ID: 1800965003148739899
  • Last Price Increase: 2024-06-12
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @alexpensify
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jun 12, 2024
Copy link

melvin-bot bot commented Jun 12, 2024

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jun 12, 2024

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

@alexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@danieldoglas
Copy link
Contributor

I think this was caused by #43270

Reverting that PR solved the issue for me locally.

@danieldoglas
Copy link
Contributor

@mollfpr @rlinoz @SzymczakJ can you please check what's going on here? Seems related to #43270

@rlinoz
Copy link
Contributor

rlinoz commented Jun 12, 2024

Indeed reverting the PR fixes it

@danieldoglas danieldoglas removed the DeployBlocker Indicates it should block deploying the API label Jun 12, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Jun 12, 2024

Not adding the excludeStyles as a dependency here https://github.com/Expensify/App/pull/43270/files#diff-a1120b846ebeebcc99d15542e13bd9537c273751a97bce6a0de03295ec98d2baR89 fixes it, but I don't understand why

@SzymczakJ
Copy link
Contributor

On it. I'll try to find solution ASAP

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Jun 12, 2024
@alexpensify alexpensify added the External Added to denote the issue can be worked on by a contributor label Jun 12, 2024
@melvin-bot melvin-bot bot changed the title Mark down - Copying and pasting part of a code block doesn't work [$250] Mark down - Copying and pasting part of a code block doesn't work Jun 12, 2024
Copy link

melvin-bot bot commented Jun 12, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01bd2b97089b315a6c

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 12, 2024
Copy link

melvin-bot bot commented Jun 12, 2024

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 12, 2024
@alexpensify
Copy link
Contributor

Ok, I've updated the assignments here to reflect everyone who is helping to address this issue.

@danieldoglas danieldoglas removed the DeployBlockerCash This issue or pull request should block deployment label Jun 13, 2024
@danieldoglas
Copy link
Contributor

Removing blocker label since it was CP'd

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jun 13, 2024
@melvin-bot melvin-bot bot changed the title [$250] Mark down - Copying and pasting part of a code block doesn't work [HOLD for payment 2024-06-20] [$250] Mark down - Copying and pasting part of a code block doesn't work Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

  • @SzymczakJ does not require payment (Contractor)
  • @situchan requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Jun 13, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@situchan] The PR that introduced the bug has been identified. Link to the PR:
  • [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@situchan] Determine if we should create a regression test for this bug.
  • [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 19, 2024
Copy link

melvin-bot bot commented Jun 20, 2024

Payment Summary

Upwork Job

  • Contributor: @SzymczakJ is from an agency-contributor and not due payment
  • ROLE: @situchan paid $250 via Upwork (LINK)

BugZero Checklist (@alexpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1800965003148739899/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@alexpensify
Copy link
Contributor

@situchan - I've sent over an offer via Upwork. Please accept, and then I can complete the payment process. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Jun 24, 2024
Copy link

melvin-bot bot commented Jun 24, 2024

@danieldoglas, @alexpensify, @SzymczakJ, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@alexpensify
Copy link
Contributor

All set here, I've completed the payment process. All actions are complete here -- closing!

@melvin-bot melvin-bot bot removed the Overdue label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

7 participants