Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Web - Track Expense - Track amount remains on LHN when IOU is removed from self-DM #43570

Closed
1 of 6 tasks
m-natarajan opened this issue Jun 12, 2024 · 14 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@m-natarajan
Copy link

m-natarajan commented Jun 12, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.82-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4621293&group_by=cases:section_id&group_id=309130&group_order=asc
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

  1. In OldDot - Create an unreported transaction
  2. Verify that it shows up on the self-DM on NewDot
  3. In OldDot - add the transaction to a report
  4. Check LHN when transaction is removed from the self-DM ( navigate to other chat or refresh the page)

Expected Result:

Track amount should disappear from LHN and This is your personal space should be present

Actual Result:

Track amount remains on LHN when IOU is removed from self-DM even user refresh the page. Track amount disappears onlywhen user navigate back to self-DM chat

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6510583_1718185581297.Recording__3172.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01018dafbf768a7c7c
  • Upwork Job ID: 1800920342613338963
  • Last Price Increase: 2024-06-12
@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jun 12, 2024
Copy link

melvin-bot bot commented Jun 12, 2024

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jun 12, 2024

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jun 12, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

@sakluger FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@m-natarajan
Copy link
Author

We think that this bug might be related to #vip-vsb

@Gonals Gonals added Daily KSv2 External Added to denote the issue can be worked on by a contributor and removed Hourly KSv2 labels Jun 12, 2024
@melvin-bot melvin-bot bot changed the title Web - Track Expense - Track amount remains on LHN when IOU is removed from self-DM [$250] Web - Track Expense - Track amount remains on LHN when IOU is removed from self-DM Jun 12, 2024
Copy link

melvin-bot bot commented Jun 12, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01018dafbf768a7c7c

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 12, 2024
Copy link

melvin-bot bot commented Jun 12, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

@Gonals
Copy link
Contributor

Gonals commented Jun 12, 2024

I think this can be fixed externally.
We don't really need to block deploy on this, though

@Gonals Gonals removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jun 12, 2024
@b4s36t4
Copy link
Contributor

b4s36t4 commented Jun 13, 2024

Verify that it shows up on the self-DM on NewDot

This is not happening for me, any help @Gonals

Copy link

melvin-bot bot commented Jun 17, 2024

@sakluger, @Gonals, @mollfpr Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Jun 17, 2024
@sakluger
Copy link
Contributor

@b4s36t4 - just to confirm, you created an unreported transaction in OldDot, then opened your self-DM in NewDot, and the new transaction is not showing up in your self-DM?

@b4s36t4
Copy link
Contributor

b4s36t4 commented Jun 18, 2024

Yes.

@sakluger
Copy link
Contributor

I also can't reproduce the issue, but experienced another bug.

  1. I created an unreported transaction in OldDot
image
  1. I opened my self-DM in NewDot. Result: The expense shows up but with the skeleton loader, no details are inside.
image
  1. I click on the expense skeleton, but all the details are missing
image

@sakluger
Copy link
Contributor

I'm going to close this as unreproducible and report the other issue.

@melvin-bot melvin-bot bot removed the Overdue label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

5 participants