Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Web - Expense - Two RHPs open when opening Add receipt modal via TAB key #43679

Closed
2 of 6 tasks
lanitochka17 opened this issue Jun 13, 2024 · 16 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed

Comments

@lanitochka17
Copy link

lanitochka17 commented Jun 13, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.83-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Go to + > Submit expense > Manual
  4. Enter amount > Next
  5. Using TAB key, open Add receipt modal (below To field, not 3-dot menu)
  6. Might need to repeat Step 5 a few times to reproduce this issue

Expected Result:

In Step 5, when opening Add receipt modal via TAB, the modal will slide smoothly from the right

Actual Result:

In Step 5, when opening Add receipt modal via TAB, two RHPs open - one is workspace chat details, another one is Add receipt modal

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6512089_1718291202757.20240613_230100.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0113c5af3ca5595eff
  • Upwork Job ID: 1801295262146054436
  • Last Price Increase: 2024-06-13
Issue OwnerCurrent Issue Owner: @jayeshmangwani
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@pecanoro FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Jun 13, 2024
@melvin-bot melvin-bot bot changed the title Web - Expense - Two RHPs open when opening Add receipt modal via TAB key [$250] Web - Expense - Two RHPs open when opening Add receipt modal via TAB key Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0113c5af3ca5595eff

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

@pecanoro pecanoro added Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlocker Indicates it should block deploying the API labels Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@pecanoro
Copy link
Contributor

I can't seem to be able to reproduce this. @jayeshmangwani @anmurali @mountiny Can you guys double check?

@jayeshmangwani
Copy link
Contributor

@pecanoro I am not able to reproduce this in main, though I can reproduce on staging

@pecanoro
Copy link
Contributor

I tried on staging and I can't haha Maybe it's some weird edge case?

@pecanoro
Copy link
Contributor

I am going to leave it open for suggestions but remove the deploy blocker label.

@pecanoro pecanoro added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jun 13, 2024
@jayeshmangwani
Copy link
Contributor

Weirdly, after trying a few times, I am now able to reproduce it on the main branch too. 😕

2-RHP.mov

@mountiny mountiny added the Needs Reproduction Reproducible steps needed label Jun 14, 2024
@mountiny
Copy link
Contributor

Also could not repro

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Copy link

melvin-bot bot commented Jun 18, 2024

@pecanoro, @anmurali, @jayeshmangwani Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Jun 18, 2024
@pecanoro
Copy link
Contributor

I am going to close it since I tried again and it seems to be working fine

@melvin-bot melvin-bot bot removed the Overdue label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

6 participants