[$250] Pay someone - Console error shows up when changing payment

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.83-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Pay someone.
3. Enter amount in any currency except USD, select a user and pay them.
4. Go to FAB > Pay someone.
5. Enter amount in USD and select the same user.
6. On confirmation page, click on the dropdown.
7. Choose Pay elsewhere.

Expected Result:

No console error will show up.

Actual Result:

Console error shows up.
[Onyx] Warning: Trying to apply "merge" with non-array type to array type in the key "nvp_private_lastPaymentMethod"

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

20240614_001248.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d201b1908116ec8e
• Upwork Job ID: 1801295301666346552
• Last Price Increase: 2024-06-13

[melvin-bot]

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

Issue have been raised in adhoc build #42772 (comment)

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d201b1908116ec8e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[mountiny]

This might not be a deploy blocker given the implications are low, but we should look into this. Can you confirm this does not cause a crash in native @kbecciv @lanitochka17 ?

[rlinoz]

Trying to reproduce this

[rlinoz]

I can reliably reproduce this and it doesn't seem to crash native.

[rlinoz]

New incompatibility logs were added in Onyx v2.0.35 Expensify/react-native-onyx#532, we went from 2.0.32 to 2.0.48 https://github.com/Expensify/App/pull/42772/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R158, so that is where it is coming from, the original problem is the backend sending the nvp_private_lastPaymentMethod as an array on OpenApp.

Looking at the changes from the PR that added the logs it doesn't look like it should crash, so we should be good

[mountiny]

Also QA confirmed this is not causing crashes in native https://expensify.slack.com/archives/C9YU7BX5M/p1718297508327499

[rlinoz]

Moving this to weekly for now, it should be fine since it is not crashing or disrupting functionality.

[rlinoz]

I have an idea on how to fix this, there is a PR in progress.

[rlinoz]

This is deployed to prod https://github.com/Expensify/Auth/pull/11371#issuecomment-2222728965