[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] mWeb - Login – Animation appears with delay when navigate via magic link in incognino tab

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.83-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4626832
Issue reported by: Applause - Internal team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log out.
3. Click on sign in button
4. Enter email.
5. Open link from email in Incognito tab and change to staging.

Expected Result:

Here is your magic code page opens with animation

Actual Result:

Here is your magic code page opens, but animation appears with delay

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen_Recording_20240614_014608_Chrome.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

Not reproducible in prod

Screen_Recording_20240614_014712_Chrome.mp4

[srikarparsi]

Verified that it's reproducible on staging and not prod. Also seems to occur on safari web.

[srikarparsi]

Pretty sure it's related to this PR @eVoloshchak @tienifr @grgia do you have any thoughts?

[tienifr]

Hmm I think animation files take time to fully load the first time so this doesn't seem a bug to me.

For Safari, we already agreed in the PR that the dottie animation file is having a problem there and we will create follow-up PR once it is resolved by design team.

[shawnborton]

Yeah, I think this isn't a deploy blocker and it's fine as-is.

[srikarparsi]

Cool sounds good, will check this off

[srikarparsi]

We are removing the animation as per this conversation

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.84-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove Magic Code Animation #43732

If no regressions arise, payment will be issued on 2024-06-24. 🎊

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove Magic Code Animation #43732

If no regressions arise, payment will be issued on 2024-06-28. 🎊

[srikarparsi]

No payment needed for this and it has been deployed to production. Closing this out