[HOLD for payment 2024-08-01] [HOLD for payment 2024-07-26] [$250] Workspace - Workspace name reverts back to previous one if created and changed offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.85-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4635388&group_by=cases:section_id&group_id=229065&group_order=asc
Issue reported by: Applause - Internal Team

Action Performed:

1. Log in with any account
2. Go offline
3. Create a workspace
4. Change it's name while offline
5. Go online

Expected Result:

Workspace name should remain as it is edited while offline

Actual Result:

Workspace name reverts back to default one (after few seconds) instead of the edited workspace name after going online. Affects Gmail and expensifail accounts too

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6514854_1718532794157.bandicam_2024-06-16_12-06-53-622.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a9ae643def6b9e4e
• Upwork Job ID: 1803905100231444547
• Last Price Increase: 2024-07-11
• Automatic offers:
• suneox | Reviewer | 103096636
• huult | Contributor | 103096638

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@johncschuster FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a9ae643def6b9e4e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[suneox]

I have double-checked this issue doesn't happen on staging build v9.0.1-0

Screen.Recording.2024-06-22.at.11.42.56.mov

[melvin-bot]

@johncschuster, @suneox Whoops! This issue is 2 days overdue. Let's get this updated quick!

[johncschuster]

Asking for a retest/clarification on repro steps in Slack

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[kavimuru]

I am able to reproduce.

Recording.1978.mp4

[johncschuster]

@suneox can you try again?

[suneox]

@suneox can you try again?

@johncschuster I have tried, and this issue able to reproduce on latest staging v9.0.2-0

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[suneox]

We're still looking proposal, I've posted to slack to get more eyes on this

[johncschuster]

Acknowledged! I will issue payment once the regression window is passed 👍

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[johncschuster]

@cristipaval, can you take a look to see if the linked PR caused a regression?

[suneox]

Hi @cristipaval, based on the selected solution, we prevent calling an update request while there is still a create request pending. However, when creating a workspace in offline mode, we don’t set pendingFields. Although this PR has raised issue #46053, but we found another root cause is missing pendingFields when creating a workspace in offline mode. Therefore, I think the scope to fix graying out the workspace in offline mode will be handled in issue #46053.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix workspace name showing previous name #45820

If no regressions arise, payment will be issued on 2024-08-01. 🎊

For reference, here are some details about the assignees on this issue:

• @suneox requires payment automatic offer (Reviewer)
• @huult requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@suneox] The PR that introduced the bug has been identified. Link to the PR:
• [@suneox] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@suneox] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@suneox] Determine if we should create a regression test for this bug.
• [@suneox] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[cristipaval]

@cristipaval, can you take a look to see if the linked PR caused a regression?

@johncschuster, as @suneox stated, the PR for this issue revealed another issue with a different root cause. They are related somehow, but I am not sure if it makes sense to add penalties here 🤔

[johncschuster]

but I am not sure if it makes sense to add penalties here 🤔

Awesome. Thanks for saying that! I won't apply regression penalties then 👍

[melvin-bot]

@johncschuster, @suneox, @cristipaval, @huult Whoops! This issue is 2 days overdue. Let's get this updated quick!

[johncschuster]

Not overdue. I'm waiting for the regression threshold window to pass (2024-08-01)

[johncschuster]

@huult I've issued your payment. Thanks for your contributions!

@suneox can you please complete the BZ Checklist? I'll issue your payment once that's complete.

[suneox]

Bugzero Checklist

• [@suneox] The PR that introduced the bug has been identified. Link to the PR: N/A: This issue handle an edge case to prevent an update request while a create request is still pending.
• [@suneox] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@suneox] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@suneox] Determine if we should create a regression test for this bug: N/A

[suneox]

@suneox can you please complete the BZ Checklist? I'll issue your payment once that's complete.

@johncschuster I have completed the checklist.

[johncschuster]

@suneox Payment has been issued! Thanks for your contributions! 🎉