[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] Web - Book travel - There is hover effect on "Save money on ..." and "Get realtime updates.."

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.1-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4661870
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Book travel
3. Hover over "Save money on your bookings" and "Get realtime updates and alerts"

Expected Result:

There will be no hover effect on "Save money on your bookings" and "Get realtime updates and alerts" (production behavior)

Actual Result:

There is hover effect on "Save money on your bookings" and "Get realtime updates and alerts"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6521550_1719065442534.20240622_220725.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Book travel - There is hover effect on "Save money on ..." and "Get realtime updates.."

What is the root cause of that problem?

The background is updated whenever isHovered && !pressed is true.

App/src/components/MenuItem.tsx

Lines 515 to 517 in 425804a

	!focused && (isHovered || pressed) && hoverAndPressStyle,
	shouldGreyOutWhenDisabled && disabled && styles.buttonOpacityDisabled,
	isHovered && !pressed && styles.hoveredComponentBG,

What changes do you think we should make in order to solve the problem?

We should also check if the item is interactive or not on both places where we update the hover styles.

!focused && interactive &&  (isHovered || pressed) && hoverAndPressStyle,
shouldGreyOutWhenDisabled && disabled && styles.buttonOpacityDisabled,
isHovered && interactive && !pressed && styles.hoveredComponentBG,

What alternative solutions did you explore? (Optional)

[ishpaul777]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Book travel - There is hover effect on "Save money on ..." and "Get realtime updates.."

What is the root cause of that problem?

Offending PR -https://github.com/Expensify/App/pull/43987/files

Here hover hoveredComponentBG is applied when isHovered && !pressed but there is no consideration when component is not interactive

App/src/components/MenuItem.tsx

Lines 515 to 517 in 425804a

	!focused && (isHovered || pressed) && hoverAndPressStyle,
	shouldGreyOutWhenDisabled && disabled && styles.buttonOpacityDisabled,
	isHovered && !pressed && styles.hoveredComponentBG,

What changes do you think we should make in order to solve the problem?

In <Hoverable> component we can pass a prop isDisabled={!interactive} to disable hover.

App/src/components/MenuItem.tsx

Line 500 in 425804a

<Hoverable>

[rojiphil]

Thanks all for the help here by tagging the offending PR and sharing the insights on the issue.
Fixing this issue here at #44219 since this is a regression from #43987
cc @MonilBhavsar

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Remove hover background for non interactive elements #44219

If no regressions arise, payment will be issued on 2024-07-02. 🎊

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[luacmartins]

Payment will be handled in #41901. Closing.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Remove hover background for non interactive elements #44219

If no regressions arise, payment will be issued on 2024-07-10. 🎊