Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add payment card - Unable to add payment card to account #44267

Closed
1 of 6 tasks
lanitochka17 opened this issue Jun 24, 2024 · 8 comments
Closed
1 of 6 tasks

Add payment card - Unable to add payment card to account #44267

lanitochka17 opened this issue Jun 24, 2024 · 8 comments
Assignees
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@lanitochka17
Copy link

lanitochka17 commented Jun 24, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.1-0
Reproducible in staging?: Y
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): rybkina+062424@gmail.com

Issue found when executing PR #43473

Action Performed:

  1. Sign up for gmail account and create collect policy in OD
  2. Navigate to https://staging.new.expensify.com/settings/subscription
  3. Add credit card details from the 1password
  4. Tap on 'Add payment card"

Case 2:
Try to add CC card:
cardNumber: '1234',
cardYear: 2026, cardMonth: 11
currency: 'USD', addressName: 'John Doe',

Expected Result:

Payment card should be add and now have next billing date info and card data

Actual Result:

Unable to add payment card to account. Popup is close Payment card doesn't added

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6522962_1719236030345.43473_mac_chrome.mp4
Bug6522962_1719236030342.case2.mp4
08 22 30

View all open jobs on GitHub

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jun 24, 2024
Copy link

melvin-bot bot commented Jun 24, 2024

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@youssef-lr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@jacobkim9881
Copy link
Contributor

Is okay to put credit card details for testing from the repro video?

@blimpich blimpich removed DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Jun 24, 2024
@blimpich
Copy link
Contributor

Not a deploy blocker because its not available to users yet. You have to know that the link exists and type it in manually to get to it.

@blimpich blimpich added Daily KSv2 and removed Hourly KSv2 labels Jun 24, 2024
@blimpich blimpich assigned blimpich and unassigned youssef-lr Jun 24, 2024
@blimpich
Copy link
Contributor

Picking up because it relates to subscription page stuff which I'm managing.

Brought discussion to slack, I think this can be closed as expected but waiting to confirm.

@jacobkim9881
Copy link
Contributor

@blimpich Thanks. I understood 😄

@blimpich blimpich added the Internal Requires API changes or must be handled by Expensify staff label Jun 25, 2024
@blimpich
Copy link
Contributor

Closing in favor of this issue: #44362

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

4 participants