Deploy Checklist: Expensify.cash 2021-08-06

[OSBotify]

Release Version: 1.0.83-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Deselect attendees when splitting bill #3881
• Add offline message to IOU and Split bill and allow currency selection while offline #4019
• Update copy to refer to new URL #4091
• [CP Staging] Remove duplicate form fields #4117
• 🍒 Cherry pick PR #4117 to staging 🍒 #4125
• fix: paste and Ctrl+z #4131
• Modify line height so text does not get cut off in LHN #4143
• 🍒 Cherry pick PR #4131 to staging 🍒 #4149
• 🍒 Cherry pick PR #4143 to staging 🍒 #4152
• 🍒 Cherry pick PR #4019 to staging 🍒 #4193
• Update version to 1.0.79-5 on staging #4197
• Update version to 1.0.79-6 on staging #4202
• Update version to 1.0.80-0 on staging #4204
• [InternalQA] Update Workspace button text during pending account validation #4237
• Make sure we get state/status from the right variable name when we get chat report name #4239
• Web - Settings - Dropdown symbol overlaps with text in the box #4243
• 🍒 Cherry pick PR #4243 to staging 🍒 #4245
• Show verification modal instead of redirecting to concierge #4246
• 🍒 Cherry pick PR #4239 to staging 🍒 #4249
• [No QA] Implement Why Did You Render #4260
• Update version to 1.0.80-3 on staging #4278
• Update version to 1.0.81-0 on staging #4282
• Fix staging due to undefined Onyx key #4286
• 🍒 Cherry pick PR #4286 to staging 🍒 #4289
• Fix: urls for user details #4291
• Allow editing of Workspace names #4298
• Fix broken list components on staging #4300
• 🍒 Cherry pick PR #4300 to staging 🍒 #4306
• Directly create a workspace and add the Edit Workspace page #4310
• Use activeComponentBG for Workspace menu items #4314
• Patch for PR #4190  #4322
• 🍒 Cherry pick PR #4322 to staging 🍒 #4327
• Update version to 1.0.81-5 on staging #4332
• Update version to 1.0.81-6 on staging #4335
• Update getPullRequestsMergedBetween to run pre-set string command #4336
• Update XCode to fix iOS deploy #4339
• Update version to 1.0.81-7 on staging #4341
• Update version to 1.0.81-8 on staging #4344
• Update version to 1.0.82-0 on staging #4347
• Perf: Add context factory helper to speed up chat switching #4348
• expensify-common hash update #4349
• Fix white screen when trying to navigate empty search results #4351
• Changes to how validation displays in UI #4354
• Fix User is able to upload a file larger than 50mb #4358
• Fix timerow should update on Language changes. #4360
• Update E-common #4363
• Fix: Selecting a language does not update in real time #4366
• 🍒 Cherry pick PR #4358 to staging 🍒 #4369
• [No QA] Switch warnCPLabel trigger from pull_request to pull_request_target #4370
• [No QA] [Performance] Approximate the ideal number of reports to render on first render #4371
• 🍒 Cherry pick PR #4339 to staging 🍒 #4373
• IOU Error Handling, navigated back to Amount Page on error #4378
• Navigation.isActiveRoute function updated to handle currentRoute logic #4382
• Meta Tweaks for #4275 #4383
• handle navigation when reportID isn't valid #4387
• 🍒 Cherry pick PR #4366 to staging 🍒 #4390
• [NO QA] Clarify risk of submitting early proposals #4391
• Treat Default Chat Rooms like Multiple Participant Rooms when it comes to their OptionRow->login property #4393
• Fixes styling for hidden element again #4394
• Fix misaligned text on Workspace Card Page #4396
• Fix: Infinite loader on login #4397
• Fix: inline messages #4399
• [No QA] Catch http errors that don't trigger .then() #4400
• Don't show loading state in workspace setup button #4401
• don't show localTime for Chronos #4403
• #2430 remove app.relaunch on desktop update #4406
• Fix Password Forms Header Title #4410
• PR changes requested #4412
• Attempt at fixing race #4416
• Fix: incorrect prop name passed for locale #4419
• Add note about generating multiple test accounts #4423
• fix: outline on sign in page #4424
• 🍒 Cherry pick PR #4416 to staging 🍒 #4428
• 🍒 Cherry pick PR #4397 to staging 🍒 #4430
• Race fix attempt 2 #4436
• 🍒 Cherry pick PR #4436 to staging 🍒 #4439
• 🍒 Cherry pick PR #4336 to staging 🍒 #4442
• Ensure workspaces show after signing in #4444
• Update version to 1.0.82-8 on staging #4446
• Update version to 1.0.82-9 on staging #4450
• Update version to 1.0.82-10 on staging #4452
• Update version to 1.0.82-11 on staging #4455
• Update version to 1.0.83-0 on staging #4458

Deploy Blockers:

• Settings - Change password - "New Expensify accounts" displayed instead "new.expensify.com" under Change Password #4482
• [HOLD for payment 2021-09-16] Desktop - Big empty space in message fields if copy/paste the Text from MAC Note.app #4484
• [HOLD for payment 2021-09-17] Workspace - Add Loading UI after user saves profile photo #4487
• Web - Chronos - Reply text for the commands "top" and "top help" are misaligned #4488
• IOU - All group participants are not displayed in the Split bill attendees #4501
• Update app modal does not display #4537

cc @Expensify/applauseleads

[AndrewGable]

@isagoico - Let us know if you see duplicates or incorrect issues added to the checklist. The bug should be fixed now. cc @Jag96

[isagoico]

Starting QA 🚀

[AndrewGable]

@roryabraham @Jag96 - Should we make a "No QA" label and apply it to cherry pick and version PRs so they don't appear in the list?

[isagoico]

PRs that should not be in the list, most are previous Cherry picks 🤔

• Add offline message to IOU and Split bill and allow currency selection while offline #4019
• [CP Staging] Remove duplicate form fields #4117
• fix: paste and Ctrl+z #4131
• Modify line height so text does not get cut off in LHN #4143
• Make sure we get state/status from the right variable name when we get chat report name #4239
• Web - Settings - Dropdown symbol overlaps with text in the box #4243
• Fix staging due to undefined Onyx key #4286
• Fix broken list components on staging #4300
• Patch for PR #4190  #4322
• Update getPullRequestsMergedBetween to run pre-set string command #4336
• Update XCode to fix iOS deploy #4339
• Fix User is able to upload a file larger than 50mb #4358
• Fix: Selecting a language does not update in real time #4366
• Fix: Infinite loader on login #4397
• Attempt at fixing race #4416
• Race fix attempt 2 #4436

[Jag96]

Should we make a "No QA" label and apply it to cherry-pick and version PRs so they don't appear in the list?

That sounds like a good initial approach, I'll create an issue and we can discuss it there: #4462

[Jag96]

PRs that should not be in the list, most are previous Cherry picks

This sounds like a different issue, if a PR was already deployed to production it shouldn't show up here. For example, in this issue we have a deployed to production comment at 7:42 PM PST and a deployed to staging comment at 8:16PM PST, so it seems like something is wrong there, but the kickoff times for the builds were pretty close. If this happens again we can investigate.

[isagoico]

Issues found so far during regression:

1. IOU - All group participants are not displayed in the Split bill attendees #4501 is failing Deselect attendees when splitting bill #3881
2. Settings - Change password - "New Expensify accounts" displayed instead "new.expensify.com" under Change Password #4482 is failing Update copy to refer to new URL #4091
3. [HOLD for payment 2021-09-16] Desktop - Big empty space in message fields if copy/paste the Text from MAC Note.app #4484 is failing Update E-common #4363
4. Web - Chronos - Reply text for the commands "top" and "top help" are misaligned #4488
5. [HOLD for payment 2021-09-17] Workspace - Add Loading UI after user saves profile photo #4487

[isagoico]

Regression is finished!
Issues found:

1. IOU - All group participants are not displayed in the Split bill attendees #4501 is failing Deselect attendees when splitting bill #3881
2. Settings - Change password - "New Expensify accounts" displayed instead "new.expensify.com" under Change Password #4482 is failing Update copy to refer to new URL #4091 (Expected behaviour)
3. [HOLD for payment 2021-09-16] Desktop - Big empty space in message fields if copy/paste the Text from MAC Note.app #4484 is failing Update E-common #4363
4. Web - Chronos - Reply text for the commands "top" and "top help" are misaligned #4488
5. [HOLD for payment 2021-09-17] Workspace - Add Loading UI after user saves profile photo #4487

These PRs need QA:

• [InternalQA] Update Workspace button text during pending account validation #4237 Internal
• Show verification modal instead of redirecting to concierge #4246 (comment) (Internal probably)

[roryabraham]

Should we make a "No QA" label and apply it to cherry pick and version PRs so they don't appear in the list?

We already have some code which should do this, but it's clearly not working as it's supposed to. Right now it should be filtering out any PRs created by OSBotify.

[roryabraham]

Just noting that PR 4446 was supposed to be filtered out, but then looking at the history of this issue, it was included in the checklist when it was first created.

[roryabraham]

Figured this out, new PRs are all in Expensify/App, but we're still using Expensify/Expensify.cash in a lot of our CI/CD code. This particular bug could probably be fixed going forward by updating this

[Jag96]

Looks like we're updating that in https://github.com/Expensify/App/pull/4408/files#diff-9cbd4a79f7ae474fbd0b49061723e1d9450e32cb96bcbf08289361b4f68896a7R97, so that should be fixed soon

[francoisl]

The DeployBlocker label was removed from #4487, can we check it off the list of blockers above?

I'm looking into #4484 right now in the meantime.

[roryabraham]

The DeployBlocker label was removed from #4487, can we check it off the list of blockers above?

Yep!

[francoisl]

Quick update on the remaining items:

• @luacmartins is QAing [InternalQA] Update Workspace button text during pending account validation #4237. Currently waiting to get his validation amounts
• Show verification modal instead of redirecting to concierge #4246 can be checked off, Kevin confirmed he did the QA with Mitch
• Update E-common #4363 / [HOLD for payment 2021-09-16] Desktop - Big empty space in message fields if copy/paste the Text from MAC Note.app #4484 doesn't look like a pure regression, it already didn't work properly on production. Not sure of the best course of action, but I'd suggest we remove the deploy blocker from [HOLD for payment 2021-09-16] Desktop - Big empty space in message fields if copy/paste the Text from MAC Note.app #4484
• The blocker issue Web - Chronos - Reply text for the commands "top" and "top help" are misaligned #4488 is closed, let's check it off in the list?

[roryabraham]

@isagoico Can we retest #4488 in 1.0.83-1?

Agreed that we should demote #4484 from deploy blocker to regular-old 🐛 and check it off the list. Even if it's not a pure regression, it's an edge case I think we can tolerate in prod for a while to push the prod deploy along.

[roryabraham]

So assuming #4488 is fixed in 1.0.83-1 (currently being deployed here), then we should be good to check off the remaining items and run a prod deploy. Thanks for the summary @francoisl!

[isagoico]

Retested #4488 and it was a pass 🎉

[isagoico]

Checking off #4363 since #4484 is not a deploy blocker anymore

[roryabraham]

#4537 is also being demoted from deploy blocker to regular bug because we realized it's already present on prod.

[francoisl]

Ok looks like everything's ready, going to close for my official first NewDot deploy :D

[francoisl]