Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint is failing on main #44494

Closed
roryabraham opened this issue Jun 26, 2024 · 4 comments
Closed

Lint is failing on main #44494

roryabraham opened this issue Jun 26, 2024 · 4 comments
Assignees
@roryabraham @adelekennedy @dukenv0307
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review Weekly KSv2

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Jun 26, 2024 •
edited by melvin-bot bot
Loading

Problem

Lint is failing with a timeout on main, just like in this CI job. This will seize up a lot of our development in E/App because we heavily rely on lint to prevent bugs and promote code quality.

Solution

Investigate and fix the issue with our lint configuration.

Issue OwnerCurrent Issue Owner: @dukenv0307
@roryabraham roryabraham added External Added to denote the issue can be worked on by a contributor Hourly KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 26, 2024
@roryabraham roryabraham self-assigned this Jun 26, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 26, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jun 26, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jun 26, 2024

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@roryabraham
Copy link
Contributor Author

this comment is very interesting

@roryabraham roryabraham mentioned this issue Jun 26, 2024
Merged
50 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Jun 26, 2024
@roryabraham
Copy link
Contributor Author

This is fixed now by simply increasing the memory given to eslint. I did try applying the diff from that comment to run lint in parallel, but actually with a cache and more memory, it was faster to run eslint in one process than in many. So I'm calling this done for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roryabraham roryabraham

@adelekennedy adelekennedy

@dukenv0307 dukenv0307

Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@roryabraham @adelekennedy @dukenv0307