Validate Step stayed open after entering validation amounts and bank account was successfully added

[kevinksullivan]

Problem

I completed the Validation amount step with kevin@kevinsullivan.xyz on NewDot, and after I got a (very fast) success modal between these two screenshots, the Validate step refreshed and stayed open.

Before validating, you'll notice my bank account has not been added or cards provisioned based on the Finish Setup button in the background.

After validating you'll notice the button says Manage Cards, as my bank account was added and cards provisioned, but the Validate step is incorrectly open.

Reproduction Steps

1. Add account to freePlan and allowSameExpensifyCardSettlementBBA betas
2. Login to new.expensify.com and select global Create
3. Choose "Create workspace"
4. Select Get Started and go through VBA flow using these credentials
5. Arrive at the Validate step where you are asked to enter 3 validation amounts
6. Exit the flow
7. Select the Finish Setup button, and see that the button changes

Solution

the Validate Step should not be shown after successfully completing it and a bank account being added.

[I think we should keep this internal for the sake of a quick turnaround]

[MelvinBot]

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[parasharrajat]

@kevinksullivan Reproductions steps are not clear. How to go to VBA flow?

[kevinksullivan]

Updated reproduction steps to be clearer @parasharrajat .

[luacmartins]

I believe I'm already solving this issue along with this https://github.com/Expensify/Expensify/issues/173086.

[pecanoro]

A bit odd, the validation modal should only show up if no cards are provisioned. I think as Carlos mentioned, it could be due to https://github.com/Expensify/Expensify/issues/173086.

[luacmartins]

Yea, we are not updating Onyx to reflect the new bank account state and currentStep after validating the bank account.

[MelvinBot]

@luacmartins Huh... This is 4 days overdue. Who can take care of this?

[MelvinBot]

@luacmartins 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[luacmartins]

Deployed to production yesterday. Closing the issue!