[$500] Web - It's possible to create a tag name "0", the app will crash when it's deleted

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.5-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Issue found when executing PR #44391

Action Performed:

1. Go to www.staging.chat.expensify.com
2. Create a new workspace and enable Tags
3. Create tag with "0" name
4. Try to delete this Tag

Expected Result:

Not possible to create tag with "0" name, when it fails, verify the tag name reverts to the previous name
Verify the error is cleared if close button is pressed

Actual Result:

It's possible to create a tag name "0", no error appears.
The app will crash when it's deleted.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6536264_1720468537392.Screen_Recording_2024-07-08_at_22.51.31.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012c39ad7db952ea6b
• Upwork Job ID: 1811206201231781305
• Last Price Increase: 2024-09-09
• Automatic offers:
• ahmedGaber93 | Reviewer | 103558323
• Krishna2323 | Contributor | 103558324

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@isabelastisser FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - It's possible to create a tag name "0", the app will crash when it's deleted

What is the root cause of that problem?

We don't prevent users from adding tag with name 0

App/src/pages/workspace/tags/WorkspaceCreateTagPage.tsx

Lines 40 to 58 in 15e67a0

	const validate = useCallback(
	(values: FormOnyxValues<typeof ONYXKEYS.FORMS.WORKSPACE_TAG_FORM>) => {
	const errors: FormInputErrors<typeof ONYXKEYS.FORMS.WORKSPACE_TAG_FORM> = {};
	const tagName = values.tagName.trim();
	const {tags} = PolicyUtils.getTagList(policyTags, 0);
	if (!ValidationUtils.isRequiredFulfilled(tagName)) {
	errors.tagName = translate('workspace.tags.tagRequiredError');
	} else if (tags?.[tagName]) {
	errors.tagName = translate('workspace.tags.existingTagError');
	} else if ([...tagName].length > CONST.TAG_NAME_LIMIT) {
	// Uses the spread syntax to count the number of Unicode code points instead of the number of UTF-16 code units.
	ErrorUtils.addErrorMessage(errors, 'tagName', translate('common.error.characterLimitExceedCounter', {length: [...tagName].length, limit: CONST.TAG_NAME_LIMIT}));
	}
	return errors;
	},
	[policyTags, translate],
	);

What changes do you think we should make in order to solve the problem?

We can check if the tag name is 0 and show an error. We can create new translation for that. We should also do that when editing the tag.

What alternative solutions did you explore? (Optional)

Result

Monosnap.screencast.2024-07-09.04-08-52.mp4

[bernhardoj]

BE issue, the API response returns the tags as an array of null.

cc: @danieldoglas

[danieldoglas]

hm, I think the backend changes didn't go out yet, so we might need to retest this after we deploy the beckend

[isabelastisser]

It's not overdue; waiting to retest this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012c39ad7db952ea6b

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[ahmedGaber93]

@danieldoglas I don't know if backend deployed or not, but I test this today and I see backend return incorrect data.

API CreatePolicyTag response for tag '0' (tags type is array).

API CreatePolicyTag response for tag '2' (tags type is object).

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[trjExpensify]

@danieldoglas @isabelastisser can we consolidate all of these "tag 0" issues into here? it seems crazy we have so many issues for this edge case that I highly doubt any real world customer will actually configure. Namely, these:

• [HOLD on #48300]Tags - When custom tag name saved as 0, employee cannot see tag option while submit expense #48394
• [$250] Tags - Existing tags are restructured when custom tag name is 0 and adding 0: 0 as tag #48300
• Tags - Custom name for state can be saved as 0 #48584

[danieldoglas]

Yes, let's add them all here.

@Krishna2323 can you also add that validation for custom tags?

[Krishna2323]

@danieldoglas, sure, but please allow me 2-3 days as I have some open PRs to work on. I think this is and edge case so we can wait a little.

[VictoriaExpensify]

Here's another one - #48584

I'm going to go ahead and close that one out

[danieldoglas]

bump @Krishna2323, let me know when you have a PR for those.

also, I understand that this is a different situation than what was initially proposed and (correctly) fixed, so I'll raise this to $500.

[melvin-bot]

Upwork job price has been updated to $500

[Krishna2323]

Thanks a lot for the raise🙏🏻, I will have the PR up within 12 hours.

[melvin-bot]

This issue has not been updated in over 15 days. @danieldoglas, @isabelastisser, @ahmedGaber93, @Krishna2323 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[Krishna2323]

@ahmedGaber93, this PR is ready for review.

[Krishna2323]

@danieldoglas, should we use the same error message for custom tag name field also?

Tag name cannot be 0. Please choose a different value.

[Krishna2323]

@danieldoglas @ahmedGaber93, do you have any idea if this PR has been deployed to production or not? These is no sign from melvin bot on the PR.

[danieldoglas]

hmm that's strange. I think it was, since it was part of the checklist as well. @ahmedGaber93 can you test if it's working in production as it should? If yes I'll add the awaiting for payment label.

[ahmedGaber93]

@danieldoglas, yes it works on production.

[danieldoglas]

@isabelastisser all yours for payment!

[isabelastisser]

Paid in Upwork. All set!

[ahmedGaber93]

@isabelastisser This issue is $500 price not $250

[isabelastisser]

Hi @ahmedGaber93, I'm sorry for the confusion! I thought that the price increase was only applied to the C+ review. I will adjust the offer price in Upwork now.