Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500 Reproducible Steps] Image not showing in chat or when clicked on. #45038

Closed
1 of 6 tasks
m-natarajan opened this issue Jul 9, 2024 · 30 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Needs Reproduction Reproducible steps needed Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Jul 9, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.5-4
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1720467060403009

Happened again today, 2024-08-24, where neither the preview nor expanded images show, reported in #expensify-bugs https://expensify.slack.com/archives/C049HHMV9SM/p1724428284702009

Deliverable

The deliverable is to provide reliable reproduction steps. This can be for either or both of the below

  1. Preview image not showing
  2. Expanded/larger image not showing once clicked on.

Action Performed:

  1. Receive an image from someone as attachment
  2. Close the laptop
  3. Reopen the laptop then navigate to the chat with image

Expected Result:

Image to show in chat and when click on the image

Actual Result:

Image not loading

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image (2)

logs-2024-07-08 19_11_09.732.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011dcb4ab5881339d8
  • Upwork Job ID: 1810773307146481264
  • Last Price Increase: 2024-07-30
Issue OwnerCurrent Issue Owner: @alitoshmatov
@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Jul 9, 2024
Copy link

melvin-bot bot commented Jul 9, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@joekaufmanexpensify
Copy link
Contributor

Hmm, I can't reproduce this. This is what I see on desktop after first receiving the image:

image

This is what I see after closing my laptop, re-opening it, and then navigating to the image:

image

@joekaufmanexpensify
Copy link
Contributor

Commented here. Closing this one for now as it doesn't appear to be consistently reproducible. Will re-open if there are additional steps to follow to reproduce this, or if others end up being able to reproduce it.

@mallenexpensify mallenexpensify changed the title Image not showing in chat or when clicked on. [$125 Reproducible Steps] Image not showing in chat or when clicked on. Jul 9, 2024
@mallenexpensify mallenexpensify added the External Added to denote the issue can be worked on by a contributor label Jul 9, 2024
@melvin-bot melvin-bot bot changed the title [$125 Reproducible Steps] Image not showing in chat or when clicked on. [$250] [$125 Reproducible Steps] Image not showing in chat or when clicked on. Jul 9, 2024
Copy link

melvin-bot bot commented Jul 9, 2024

Job added to Upwork: https://www.upwork.com/jobs/~011dcb4ab5881339d8

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 9, 2024
Copy link

melvin-bot bot commented Jul 9, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

@mallenexpensify
Copy link
Contributor

@alitoshmatov , can you attempt reproduction and document your findings? Thx

Copy link

melvin-bot bot commented Jul 15, 2024

@mallenexpensify, @alitoshmatov Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Jul 15, 2024
@alitoshmatov
Copy link
Contributor

Not reproducible on staging. But we have similar issue which is image is not loading on dev, could be related #44566

@melvin-bot melvin-bot bot removed the Overdue label Jul 16, 2024
Copy link

melvin-bot bot commented Jul 16, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@ikevin127
Copy link
Contributor

If this was reported by Matt then I assume it was occuring on either of adhoc, staging or production and this means it's most likely not related to #44566 as it's only reproducible in dev mode where the root cause there is StrictMode.

If this one is not reproducible anymore (for Matt either) then it must've been BE related, maybe API issues.

@mallenexpensify
Copy link
Contributor

I haven't been able to reproduce and it hasn't happened again. I'm on staging.
Will leave open cuz we'll compensate for reproducible steps, if a contributor is able to reliably reproduce.

@melvin-bot melvin-bot bot added the Overdue label Jul 18, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

Copy link

melvin-bot bot commented Jul 19, 2024

@mallenexpensify, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mallenexpensify
Copy link
Contributor

Just had it happen where the preview doesn't show but when I click on the image the full size does (and the next preview image does show)
image

Copy link

melvin-bot bot commented Jul 23, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Jul 23, 2024

@mallenexpensify @alitoshmatov this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Jul 23, 2024

@mallenexpensify, @alitoshmatov 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Copy link

melvin-bot bot commented Jul 25, 2024

@mallenexpensify, @alitoshmatov Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

Copy link

melvin-bot bot commented Jul 29, 2024

@mallenexpensify, @alitoshmatov 12 days overdue. Walking. Toward. The. Light...

Copy link

melvin-bot bot commented Jul 30, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@mallenexpensify
Copy link
Contributor

Had another instance a few days ago where the image didn't show but once I clicked on it, it did. ¯_(ツ)_/¯

@mallenexpensify mallenexpensify changed the title [$250] [$125 Reproducible Steps] Image not showing in chat or when clicked on. [$250 Reproducible Steps] Image not showing in chat or when clicked on. Jul 31, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Aug 1, 2024
Copy link

melvin-bot bot commented Aug 1, 2024

This issue has not been updated in over 14 days. @mallenexpensify, @alitoshmatov eroding to Weekly issue.

@melvin-bot melvin-bot bot removed the Overdue label Aug 1, 2024
Copy link

melvin-bot bot commented Aug 6, 2024

@mallenexpensify @alitoshmatov this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

@mallenexpensify
Copy link
Contributor

Hasn't happened recently, going to close.

@mallenexpensify mallenexpensify changed the title [$250 Reproducible Steps] Image not showing in chat or when clicked on. [$500 Reproducible Steps] Image not showing in chat or when clicked on. Aug 23, 2024
@MonilBhavsar
Copy link
Contributor

Reproduction steps could be

  1. Send a message with image
  2. Edit the message
  3. Wait for some time till the cache expires?

💥 Users no longer see the image

I recall it was related to image caching issue and @kidroca was working on it?

@mallenexpensify
Copy link
Contributor

ooooh, it looks like you're right Monil, both images have had edited text!! 🕵️
image

image

@mallenexpensify mallenexpensify removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 23, 2024
@mallenexpensify
Copy link
Contributor

There's another, older issue that's likely a dupe of this. Need to find and link, likely close this one

@kidroca
Copy link
Contributor

kidroca commented Aug 27, 2024

It might appear the problem is related to caching, but it's not caused by it. Cache just delays the problem until cache expires.

Here's the original issue and explanation why it happens: #42206 (comment). In short after editing a comment the source attribute from the image is lost (even if you haven't modified the image address)

It's a backend issue and AFAIK, there was one failed attempt to fix it

@mallenexpensify
Copy link
Contributor

Thanks @kidroca , I'm going to close this and move the convo over to #42206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Needs Reproduction Reproducible steps needed Weekly KSv2
Projects
None yet
Development

No branches or pull requests

9 participants